From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59650)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SRQTh-0000Qy-Es
	for qemu-devel@nongnu.org; Mon, 07 May 2012 12:08:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SRQTf-0003Lp-C2
	for qemu-devel@nongnu.org; Mon, 07 May 2012 12:08:01 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:43215)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SRQTf-0003Ld-1d
	for qemu-devel@nongnu.org; Mon, 07 May 2012 12:07:59 -0400
Received: by yenm4 with SMTP id m4so1869729yen.4
	for <qemu-devel@nongnu.org>; Mon, 07 May 2012 09:07:57 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Mon, 7 May 2012 11:07:52 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120507160752.GB3369@illuin>
References: <1336162822-13161-1-git-send-email-lcapitulino@redhat.com>
	<1336162822-13161-3-git-send-email-lcapitulino@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1336162822-13161-3-git-send-email-lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/6] qemu-ga: don't warn on no command
	return
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mprivozn@redhat.com

On Fri, May 04, 2012 at 05:20:18PM -0300, Luiz Capitulino wrote:
> This is a valid condition when a command chooses to not emit a
> success response.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  qemu-ga.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/qemu-ga.c b/qemu-ga.c
> index 216be39..3547119 100644
> --- a/qemu-ga.c
> +++ b/qemu-ga.c
> @@ -488,8 +488,6 @@ static void process_command(GAState *s, QDict *req)
>              g_warning("error sending response: %s", strerror(ret));
>          }
>          qobject_decref(rsp);
> -    } else {
> -        g_warning("error getting response");
>      }
>  }
> 
> -- 
> 1.7.9.2.384.g4a92a
>