From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRRDl-0001fg-9D for qemu-devel@nongnu.org; Mon, 07 May 2012 12:55:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRRDj-0008Gj-JZ for qemu-devel@nongnu.org; Mon, 07 May 2012 12:55:36 -0400 Received: from mail-gh0-f173.google.com ([209.85.160.173]:54055 helo=mail-gy0-f173.google.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRRDj-0008GY-CV for qemu-devel@nongnu.org; Mon, 07 May 2012 12:55:35 -0400 Received: by ghrr14 with SMTP id r14so5386627ghr.4 for ; Mon, 07 May 2012 09:55:33 -0700 (PDT) Sender: fluxion Date: Mon, 7 May 2012 11:55:28 -0500 From: Michael Roth Message-ID: <20120507165528.GD3369@illuin> References: <1336162822-13161-1-git-send-email-lcapitulino@redhat.com> <1336162822-13161-5-git-send-email-lcapitulino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1336162822-13161-5-git-send-email-lcapitulino@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mprivozn@redhat.com On Fri, May 04, 2012 at 05:20:20PM -0300, Luiz Capitulino wrote: > Today, qemu-ga may not be able to emit a success response when > guest-suspend-disk completes. This happens because the VM may > vanish before qemu-ga is able to emit a response. > > This semantic is a bit confusing, as it's not clear for clients if > they should wait for a response or how they should check for success. > > This commit solves that problem by changing guest-suspend-disk to > never emit a success response and suggests in the documentation > what clients could do to check for success. > > Signed-off-by: Luiz Capitulino > --- > qapi-schema-guest.json | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json > index 0aa9f91..8ea7805 100644 > --- a/qapi-schema-guest.json > +++ b/qapi-schema-guest.json > @@ -361,17 +361,19 @@ > # For the best results it's strongly recommended to have the pm-utils > # package installed in the guest. > # > -# Returns: nothing on success > +# Returns: This command does NOT return a response on success. There's a > +# high chance the command succeeded if the VM exits with a zero exit status, > +# but the VM could also exit due to other reasons. Similar suggestion as previous patch (adding a note about query-status) > +# > +# The following errors may be returned: > # If suspend to disk is not supported, Unsupported > # > -# Notes: o This is an asynchronous request. There's no guarantee a response > -# will be sent > -# o It's strongly recommended to issue the guest-sync command before > -# sending commands when the guest resumes > +# Notes: It's strongly recommended to issue the guest-sync command before > +# sending commands when the guest resumes > # > # Since: 1.1 > ## > -{ 'command': 'guest-suspend-disk' } > +{ 'command': 'guest-suspend-disk', 'success-response': 'no' } > > ## > # @guest-suspend-ram > -- > 1.7.9.2.384.g4a92a >