From: Philipp Hahn <hahn@univention.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Rate limit vnc_write_pixels_generic
Date: Mon, 7 May 2012 17:04:04 +0200 [thread overview]
Message-ID: <201205071704.09810.hahn@univention.de> (raw)
In-Reply-To: <4FA7DA0D.6030303@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
Hello Anthony,
Am Montag 07 Mai 2012 16:19:57 schrieb Anthony Liguori:
> On 05/07/2012 08:58 AM, Philipp Hahn wrote:
> > Only print the error message once per change and also include the actual
> > unsupported color depth in bytes per pixel in the error message.
> >
> > Signed-off-by: Philipp Hahn<hahn@univention.de>
>
> Under what conditions are you seeing this happen?
Actually the kvm-version I'm seeing this on is a custom build from one of our
partners with a custom RDP/RemoteFX extension they're working on. That
versions currently spams my console with the message:
2012-05-07 14:16:21.363: starting up
vnc_write_pixels_generic: VncState color depth not supported
... 767 lines removed ...
2012-05-07 14:16:42.998: shutting down
That's 36 messages per second. So I looked up the source code and found that
line, where I don't even see which bpp fails. At least that info I would find
very helpful, the rate limiting was just a bonus.
Sincerely
Philipp
--
Philipp Hahn Open Source Software Engineer hahn@univention.de
Univention GmbH be open. fon: +49 421 22 232- 0
Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99
http://www.univention.de/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2012-05-07 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 13:58 [Qemu-devel] [PATCH] Rate limit vnc_write_pixels_generic Philipp Hahn
2012-05-07 14:19 ` Anthony Liguori
2012-05-07 15:04 ` Philipp Hahn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205071704.09810.hahn@univention.de \
--to=hahn@univention.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).