From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRPU4-0001kt-2z for qemu-devel@nongnu.org; Mon, 07 May 2012 11:04:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRPTx-0007cN-Js for qemu-devel@nongnu.org; Mon, 07 May 2012 11:04:19 -0400 Received: from mail.univention.de ([82.198.197.8]:2046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRPTx-0007c0-D2 for qemu-devel@nongnu.org; Mon, 07 May 2012 11:04:13 -0400 From: Philipp Hahn Date: Mon, 7 May 2012 17:04:04 +0200 References: <4FA7DA0D.6030303@us.ibm.com> In-Reply-To: <4FA7DA0D.6030303@us.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1882693.P2NybrVdJy"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201205071704.09810.hahn@univention.de> Subject: Re: [Qemu-devel] [PATCH] Rate limit vnc_write_pixels_generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org --nextPart1882693.P2NybrVdJy Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hello Anthony, Am Montag 07 Mai 2012 16:19:57 schrieb Anthony Liguori: > On 05/07/2012 08:58 AM, Philipp Hahn wrote: > > Only print the error message once per change and also include the actual > > unsupported color depth in bytes per pixel in the error message. > > > > Signed-off-by: Philipp Hahn > > Under what conditions are you seeing this happen? Actually the kvm-version I'm seeing this on is a custom build from one of o= ur=20 partners with a custom RDP/RemoteFX extension they're working on. That=20 versions currently spams my console with the message: 2012-05-07 14:16:21.363: starting up vnc_write_pixels_generic: VncState color depth not supported =2E.. 767 lines removed ... 2012-05-07 14:16:42.998: shutting down That's 36 messages per second. So I looked up the source code and found tha= t=20 line, where I don't even see which bpp fails. At least that info I would fi= nd=20 very helpful, the rate limiting was just a bonus. Sincerely Philipp =2D-=20 Philipp Hahn Open Source Software Engineer hahn@univention.de Univention GmbH be open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/ --nextPart1882693.P2NybrVdJy Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAk+n5GUACgkQYPlgoZpUDjkhHwCcDQz+oYqBPoRHWB/JQOB/QIB9 YB8AoJUdQyc6NxBQ5xaPy/BCVB//5Q6H =4qUK -----END PGP SIGNATURE----- --nextPart1882693.P2NybrVdJy--