From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36862)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dwg@au1.ibm.com>) id 1SS5fD-0006gm-65
	for qemu-devel@nongnu.org; Wed, 09 May 2012 08:06:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dwg@au1.ibm.com>) id 1SS5f7-000450-VD
	for qemu-devel@nongnu.org; Wed, 09 May 2012 08:06:38 -0400
Received: from e23smtp02.au.ibm.com ([202.81.31.144]:56543)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dwg@au1.ibm.com>) id 1SS5f7-00043T-EV
	for qemu-devel@nongnu.org; Wed, 09 May 2012 08:06:33 -0400
Received: from /spool/local
	by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <dwg@au1.ibm.com>;
	Wed, 9 May 2012 11:47:58 +1000
Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])
	by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q49Bx7sE56361210
	for <qemu-devel@nongnu.org>; Wed, 9 May 2012 21:59:07 +1000
Received: from d23av01.au.ibm.com (loopback [127.0.0.1])
	by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q49C68CO002837
	for <qemu-devel@nongnu.org>; Wed, 9 May 2012 22:06:09 +1000
Date: Wed, 9 May 2012 22:06:01 +1000
From: David Gibson <dwg@au1.ibm.com>
Message-ID: <20120509120601.GA10235@truffala.fritz.box>
References: <1336555446-20180-1-git-send-email-jim@meyering.net>
	<1336555446-20180-15-git-send-email-jim@meyering.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1336555446-20180-15-git-send-email-jim@meyering.net>
Subject: Re: [Qemu-devel] [PATCH 14/22] vscsi: avoid unwarranted strncpy
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jim Meyering <jim@meyering.net>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Benjamin Herrenschmidt <benh@au1.ibm.com>, Jim Meyering <meyering@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Christoph Hellwig <hch@lst.de>

On Wed, May 09, 2012 at 11:23:58AM +0200, Jim Meyering wrote:
> From: Jim Meyering <meyering@redhat.com>
> 
> Don't use strncpy when the source string is known to fit
> in the destination buffer.  Use equivalent memcpy.
> We could even use strcpy, here, but some static analyzers
> warn about that, so don't add new uses.
> 
> Signed-off-by: Jim Meyering <meyering@redhat.com>

Acked-by: David Gibson <david@gibson.dropbear.id.au>

\-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson