From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mprivozn@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands
Date: Wed, 9 May 2012 15:03:35 -0500 [thread overview]
Message-ID: <20120509200335.GA18250@illuin> (raw)
In-Reply-To: <1336497889-23730-1-git-send-email-lcapitulino@redhat.com>
On Tue, May 08, 2012 at 02:24:43PM -0300, Luiz Capitulino wrote:
> This series changes qemu-ga to not emit a success response for commands
> guest-shutdown and guest-suspend-{ram,disk,hybrid}. More details and the
> reason for this change can be found in the following patches.
Looks good. Tested the affected RPCs and everything seems to work as expected.
Applied to qemu-ga queue.
>
> V2
>
> o Rename option_is_enabled() to option_value_matches() [Michael]
> o Improve guest-shutdown and guest-suspend-* docs [Michael]
>
> qapi-schema-guest.json | 56 +++++++++++++++++++++++++++++-----------------
> qapi/qmp-core.h | 10 ++++++++-
> qapi/qmp-dispatch.c | 8 +++++--
> qapi/qmp-registry.c | 4 +++-
> qemu-ga.c | 2 --
> scripts/qapi-commands.py | 14 ++++++++++--
> 6 files changed, 66 insertions(+), 28 deletions(-)
>
next prev parent reply other threads:[~2012-05-09 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 17:24 [Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands Luiz Capitulino
2012-05-08 17:24 ` [Qemu-devel] [PATCH 1/6] qapi: add support for command options Luiz Capitulino
2012-05-08 17:24 ` [Qemu-devel] [PATCH 2/6] qemu-ga: don't warn on no command return Luiz Capitulino
2012-05-08 17:24 ` [Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response Luiz Capitulino
2012-05-08 17:24 ` [Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: " Luiz Capitulino
2012-05-08 17:24 ` [Qemu-devel] [PATCH 5/6] qemu-ga: guest-suspend-ram: " Luiz Capitulino
2012-05-08 17:24 ` [Qemu-devel] [PATCH 6/6] qemu-ga: guest-suspend-hybrid: " Luiz Capitulino
2012-05-09 20:03 ` Michael Roth [this message]
2012-05-09 20:34 ` [Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509200335.GA18250@illuin \
--to=mdroth@linux.vnet.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=mprivozn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).