From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSD6u-0008Hh-Ns for qemu-devel@nongnu.org; Wed, 09 May 2012 16:03:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSD6t-0008Qm-1Z for qemu-devel@nongnu.org; Wed, 09 May 2012 16:03:44 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:64528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSD6s-0008PG-QA for qemu-devel@nongnu.org; Wed, 09 May 2012 16:03:42 -0400 Received: by obbwd20 with SMTP id wd20so865775obb.4 for ; Wed, 09 May 2012 13:03:40 -0700 (PDT) Sender: fluxion Date: Wed, 9 May 2012 15:03:35 -0500 From: Michael Roth Message-ID: <20120509200335.GA18250@illuin> References: <1336497889-23730-1-git-send-email-lcapitulino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1336497889-23730-1-git-send-email-lcapitulino@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mprivozn@redhat.com On Tue, May 08, 2012 at 02:24:43PM -0300, Luiz Capitulino wrote: > This series changes qemu-ga to not emit a success response for commands > guest-shutdown and guest-suspend-{ram,disk,hybrid}. More details and the > reason for this change can be found in the following patches. Looks good. Tested the affected RPCs and everything seems to work as expected. Applied to qemu-ga queue. > > V2 > > o Rename option_is_enabled() to option_value_matches() [Michael] > o Improve guest-shutdown and guest-suspend-* docs [Michael] > > qapi-schema-guest.json | 56 +++++++++++++++++++++++++++++----------------- > qapi/qmp-core.h | 10 ++++++++- > qapi/qmp-dispatch.c | 8 +++++-- > qapi/qmp-registry.c | 4 +++- > qemu-ga.c | 2 -- > scripts/qapi-commands.py | 14 ++++++++++-- > 6 files changed, 66 insertions(+), 28 deletions(-) >