From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36020)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1SSBQy-0005lW-Ik
	for qemu-devel@nongnu.org; Wed, 09 May 2012 14:16:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1SSBQs-0003zW-BC
	for qemu-devel@nongnu.org; Wed, 09 May 2012 14:16:20 -0400
From: Michael Walle <michael@walle.cc>
Date: Wed, 9 May 2012 20:16:10 +0200
References: <1336318514-30906-1-git-send-email-afaerber@suse.de>
	<1336318514-30906-75-git-send-email-afaerber@suse.de>
In-Reply-To: <1336318514-30906-75-git-send-email-afaerber@suse.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201205092016.10955.michael@walle.cc>
Subject: Re: [Qemu-devel] [PATCH for-next 74/74] Kill off cpu_state_reset()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?q?F=C3=A4rber?= <afaerber@suse.de>
Cc: "Peter Maydell (maintainer:ARM)" <peter.maydell@linaro.org>, qemu-devel@nongnu.org, "Alexander Graf (maintainer:PowerPC)" <agraf@suse.de>, "Blue Swirl (maintainer:SPARC)" <blauwirbel@gmail.com>, "Max Filippov (maintainer:Xtensa)" <jcmvbkbc@gmail.com>, "open list:PowerPC" <qemu-ppc@nongnu.org>, "Paul Brook (maintainer:ARM)" <paul@codesourcery.com>, Anthony Liguori <anthony@codemonkey.ws>, "Edgar E. Iglesias (maintainer:CRIS)" <edgar.iglesias@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, "Aurelien Jarno (odd fixer:MIPS)" <aurelien@aurel32.net>

> In commit 1bba0dc932e8826a7d030df3767daf0bc339f9a2 cpu_reset()
> was renamed to cpu_state_reset(), to allow introducing a new cpu_reset()
> that would operate on QOM objects.
>=20
> All callers have been updated except for one in target-mips, so drop all
> implementations except for the one in target-mips and move the
> declaration there until MIPSCPU reset can be fully QOM'ified.
>=20
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>

[..]

> diff --git a/target-lm32/helper.c b/target-lm32/helper.c
> index 3b1cee7..1ea477f 100644
> --- a/target-lm32/helper.c
> +++ b/target-lm32/helper.c
> @@ -233,9 +233,3 @@ void cpu_lm32_set_phys_msb_ignore(CPULM32State *env,
> int value) env->flags &=3D ~LM32_FLAG_IGNORE_MSB;
>      }
>  }
> -
> -void cpu_state_reset(CPULM32State *env)
> -{
> -    cpu_reset(ENV_GET_CPU(env));
> -}
> -

Acked-by: Michael Walle <michael@walle.cc>