From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jiang Liu <liuj97@gmail.com>
Cc: linux-pci@vger.kernel.org, seabios@seabios.org,
qemu-devel@nongnu.org, jbarnes@virtuousgeek.org, rjw@sisk.pl,
Alex Williamson <alex.williamson@redhat.com>,
kevin@koconnor.net, Amos Kong <akong@redhat.com>
Subject: Re: [Qemu-devel] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables
Date: Thu, 10 May 2012 20:03:47 +0300 [thread overview]
Message-ID: <20120510170345.GC14647@redhat.com> (raw)
In-Reply-To: <4FABF1DD.7090101@gmail.com>
On Fri, May 11, 2012 at 12:50:37AM +0800, Jiang Liu wrote:
> On 05/09/2012 09:47 PM, Alex Williamson wrote:
> >> ---
> >> src/ssdt-pcihp.dsl | 17
> >> src/ssdt-pcihp.hex | 8869 +++++++++++++++++++++++++++++++++++++++++++++++++++-
> >> 2 files changed, 8781 insertions(+), 105 deletions(-)
> >>
> >> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl
> >> index 4b435b8..2a3c326 100644
> >> --- a/src/ssdt-pcihp.dsl
> >> +++ b/src/ssdt-pcihp.dsl
> >> @@ -17,14 +17,23 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1)
> >> // at runtime, if the slot is detected to not support hotplug.
> >> // Extract the offset of the address dword and the
> >> // _EJ0 name to allow this patching.
> >> -#define hotplug_slot(slot) \
> >> - Device (S##slot) { \
> >> +#define hotplug_func(slot, fn) \
> >> + Device (S##slot##fn) { \
> >> ACPI_EXTRACT_NAME_DWORD_CONST aml_adr_dword \
> >> - Name (_ADR, 0x##slot##0000) \
> >
> > I would have guessed it to be sufficient to change _ADR to
> > 0x##slot##ffff, does that not work? Thanks,
> >
> > Alex
> Currently Linux acpiphp driver doesn't support that yet.
>
> --gerry
If memory serves neither does windows.
next prev parent reply other threads:[~2012-05-10 17:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111214010645.GA2044@morn.localdomain>
2012-05-09 7:24 ` [Qemu-devel] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables Amos Kong
2012-05-09 7:35 ` Amos Kong
2012-05-09 8:46 ` Michael S. Tsirkin
2012-05-09 8:59 ` Amos Kong
2012-05-09 9:53 ` Amos Kong
2012-05-09 13:47 ` Alex Williamson
2012-05-09 16:08 ` Amos Kong
2012-05-10 16:50 ` Jiang Liu
2012-05-10 17:03 ` Michael S. Tsirkin [this message]
2012-05-10 17:17 ` Jiang Liu
2012-05-10 17:42 ` Michael S. Tsirkin
2012-05-10 17:46 ` Jiang Liu
2012-05-10 23:40 ` Amos Kong
2012-05-11 10:14 ` [Qemu-devel] [SeaBIOS] " Gleb Natapov
2012-05-11 15:44 ` Jiang Liu
2012-05-11 17:04 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510170345.GC14647@redhat.com \
--to=mst@redhat.com \
--cc=akong@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kevin@koconnor.net \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rjw@sisk.pl \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).