From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34340)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SSWmN-0006bj-8N
	for qemu-devel@nongnu.org; Thu, 10 May 2012 13:03:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SSWmK-0001aR-Pv
	for qemu-devel@nongnu.org; Thu, 10 May 2012 13:03:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53880)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SSWmK-0001a1-Hw
	for qemu-devel@nongnu.org; Thu, 10 May 2012 13:03:48 -0400
Date: Thu, 10 May 2012 20:03:47 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120510170345.GC14647@redhat.com>
References: <20111214010645.GA2044@morn.localdomain>
	<20120509072452.14872.92530.stgit@t>
	<1336571221.12477.136.camel@bling.home>
	<4FABF1DD.7090101@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FABF1DD.7090101@gmail.com>
Subject: Re: [Qemu-devel] [RESEND PATCH v3] hotplug: add device per func in
 ACPI DSDT tables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jiang Liu <liuj97@gmail.com>
Cc: linux-pci@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org, jbarnes@virtuousgeek.org, rjw@sisk.pl, Alex Williamson <alex.williamson@redhat.com>, kevin@koconnor.net, Amos Kong <akong@redhat.com>

On Fri, May 11, 2012 at 12:50:37AM +0800, Jiang Liu wrote:
> On 05/09/2012 09:47 PM, Alex Williamson wrote:
> >> ---
> >>  src/ssdt-pcihp.dsl |   17 
> >>  src/ssdt-pcihp.hex | 8869 +++++++++++++++++++++++++++++++++++++++++++++++++++-
> >>  2 files changed, 8781 insertions(+), 105 deletions(-)
> >>
> >> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl
> >> index 4b435b8..2a3c326 100644
> >> --- a/src/ssdt-pcihp.dsl
> >> +++ b/src/ssdt-pcihp.dsl
> >> @@ -17,14 +17,23 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1)
> >>          // at runtime, if the slot is detected to not support hotplug.
> >>          // Extract the offset of the address dword and the
> >>          // _EJ0 name to allow this patching.
> >> -#define hotplug_slot(slot)                              \
> >> -        Device (S##slot) {                              \
> >> +#define hotplug_func(slot, fn)                          \
> >> +        Device (S##slot##fn) {                          \
> >>             ACPI_EXTRACT_NAME_DWORD_CONST aml_adr_dword  \
> >> -           Name (_ADR, 0x##slot##0000)                  \
> > 
> > I would have guessed it to be sufficient to change _ADR to
> > 0x##slot##ffff, does that not work?  Thanks,
> > 
> > Alex
> Currently Linux acpiphp driver doesn't support that yet.
> 
> --gerry

If memory serves neither does windows.