From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSXrJ-0003O1-1B for qemu-devel@nongnu.org; Thu, 10 May 2012 14:13:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSXrG-00041E-RG for qemu-devel@nongnu.org; Thu, 10 May 2012 14:13:00 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:36799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSXrG-00040T-Jb for qemu-devel@nongnu.org; Thu, 10 May 2012 14:12:58 -0400 Received: by obbwd20 with SMTP id wd20so2483705obb.4 for ; Thu, 10 May 2012 11:12:56 -0700 (PDT) Sender: fluxion Date: Thu, 10 May 2012 13:12:51 -0500 From: Michael Roth Message-ID: <20120510181251.GE17353@illuin> References: <20120510162606.15504.39510.stgit@t> <4FABFB0C.7010801@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FABFB0C.7010801@redhat.com> Subject: Re: [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, Amos Kong On Thu, May 10, 2012 at 11:29:48AM -0600, Eric Blake wrote: > On 05/10/2012 10:27 AM, Amos Kong wrote: > > Those patches updated help functions in qemu-socket.c, > > and used them in migrate-tcp.c to supporting IPv6 migration. > > > > > --- > > > > Amos Kong (4): > > qerror: add five qerror strings > > sockets: change inet_connect() to support nonblock socket > > sockets: use error class to pass listen error > > use inet_listen()/inet_connect() to support ipv6 migration > > I'm trying to understand the scope of this series, and how it might > impact what libvirt needs to support for migration in an IPv6 > environment. Is the point of this patch that IPv6 migration was > previously not possible, and is now possible using [IP6addr]:port notation? Looks like Amos went offline: but yes, in a nutshell. addr parsing now relies on qemu-sockets.c:inet_parse(), which has supported [ip6addr]:port for a while, as opposed to net.c:parse_host_port(), which didn't. Additional Error-handling was added to qemu-sockets.c:inet_connect()/inet_listen(), along with non-blocking support for inet_connect(), to subsume the ad-hoc client/server setup in migration-tcp.c > > -- > Eric Blake eblake@redhat.com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >