From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SSYZc-0005n1-61
	for qemu-devel@nongnu.org; Thu, 10 May 2012 14:58:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SSYZa-0006E3-Ao
	for qemu-devel@nongnu.org; Thu, 10 May 2012 14:58:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40572)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SSYZa-0006D7-1t
	for qemu-devel@nongnu.org; Thu, 10 May 2012 14:58:46 -0400
Date: Thu, 10 May 2012 21:58:46 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120510185845.GK14647@redhat.com>
References: <cover.1336674131.git.jan.kiszka@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1336674131.git.jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] msi: Refactorings and reset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Isaku Yamahata <yamahata@valinux.co.jp>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

On Thu, May 10, 2012 at 03:22:11PM -0300, Jan Kiszka wrote:
> These patches had been sent before. I now rebased them and reduced them
> to a set that has a value independent of the ongoing MSI rework for KVM
> integration.
> 
> I'm not yet sure if patch 1&2 should be considered for 1.1 as they
> implicitly fix the missing msi_reset for intel-hda and ahci. An
> alternative could be to add those reset calls the classic way and leave
> the refactoring for post-1.1. Maybe Gerd and Alex can comment on this.

I'd prefer that for 1.1, core changes are an unnecessary risk for 1.1.

> CC: Alexander Graf <agraf@suse.de>
> CC: Gerd Hoffmann <kraxel@redhat.com>
> CC: Isaku Yamahata <yamahata@valinux.co.jp>
> 
> Jan Kiszka (5):
>   msi: Guard msi_reset with msi_present
>   msi: Invoke msi/msix_reset from PCI core
>   msi: Guard msi/msix_write_config with msi_present
>   msi: Invoke msi/msix_write_config from PCI core
>   msi: Use msi/msix_present more consistently
> 
>  hw/ide/ich.c            |    8 --------
>  hw/intel-hda.c          |   12 ------------
>  hw/ioh3420.c            |    3 +--
>  hw/msi.c                |   11 ++++++++---
>  hw/msix.c               |   15 +++++++++------
>  hw/pci.c                |    8 ++++++++
>  hw/pci_bridge.c         |    4 ++++
>  hw/virtio-pci.c         |    3 ---
>  hw/xio3130_downstream.c |    3 +--
>  hw/xio3130_upstream.c   |    3 +--
>  10 files changed, 32 insertions(+), 38 deletions(-)
> 
> -- 
> 1.7.3.4