From: Alex Williamson <alex.williamson@redhat.com>
To: benh@kernel.crashing.org, aik@ozlabs.ru,
david@gibson.dropbear.id.au, joerg.roedel@amd.com,
dwmw2@infradead.org
Cc: aafabbri@cisco.com, alex.williamson@redhat.com,
kvm@vger.kernel.org, B07421@freescale.com,
linux-pci@vger.kernel.org, konrad.wilk@oracle.com, agraf@suse.de,
qemu-devel@nongnu.org, chrisw@sous-sol.org, B08248@freescale.com,
iommu@lists.linux-foundation.org, avi@redhat.com,
gregkh@linuxfoundation.org, bhelgaas@google.com,
linux-kernel@vger.kernel.org, benve@cisco.com
Subject: [Qemu-devel] [PATCH 06/13] iommu: Make use of DMA quirking and ACS enabled check for groups
Date: Fri, 11 May 2012 16:56:09 -0600 [thread overview]
Message-ID: <20120511225609.30496.92191.stgit@bling.home> (raw)
In-Reply-To: <20120511222148.30496.68571.stgit@bling.home>
Incorporate DMA quirking and ACS checking into amd_iommu and
intel-iommu. Note that IOMMU groups are not yet used for
streaming DMA, so this doesn't immediately solve the problems
with broken Ricoh devices.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
drivers/iommu/amd_iommu.c | 3 +++
drivers/iommu/intel-iommu.c | 3 +++
drivers/pci/pci.h | 1 +
3 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index b7e5ddf..a165311 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -291,6 +291,9 @@ static int iommu_init_device(struct device *dev)
dma_pdev = pci_get_slot(pdev->bus,
PCI_DEVFN(PCI_SLOT(pdev->devfn), 0));
+ dma_pdev = pci_dma_quirk(dma_pdev);
+ dma_pdev = pci_acs_enabled(dma_pdev);
+
group = iommu_group_get(&dma_pdev->dev);
if (!group) {
group = iommu_group_alloc();
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index e63b33b..5f526c7 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -4113,6 +4113,9 @@ static int intel_iommu_add_device(struct device *dev)
dma_pdev = pci_get_slot(pdev->bus,
PCI_DEVFN(PCI_SLOT(pdev->devfn), 0));
+ dma_pdev = pci_dma_quirk(dma_pdev);
+ dma_pdev = pci_acs_enabled(dma_pdev);
+
group = iommu_group_get(&dma_pdev->dev);
if (!group) {
group = iommu_group_alloc();
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index e494347..e8f2f8f 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -310,6 +310,7 @@ static inline resource_size_t pci_resource_alignment(struct pci_dev *dev,
}
extern void pci_enable_acs(struct pci_dev *dev);
+extern struct pci_dev *pci_acs_enabled(struct pci_dev *dev);
struct pci_dev_reset_methods {
u16 vendor;
next prev parent reply other threads:[~2012-05-11 22:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 22:55 [Qemu-devel] [PATCH 00/13] IOMMU Groups + VFIO Alex Williamson
2012-05-11 22:55 ` [Qemu-devel] [PATCH 01/13] driver core: Add iommu_group tracking to struct device Alex Williamson
2012-05-11 23:38 ` Greg KH
2012-05-11 23:58 ` Alex Williamson
2012-05-12 0:00 ` Greg KH
2012-05-11 22:55 ` [Qemu-devel] [PATCH 02/13] iommu: IOMMU Groups Alex Williamson
2012-05-11 23:39 ` Greg KH
2012-05-11 23:58 ` Alex Williamson
2012-05-14 1:16 ` David Gibson
2012-05-14 17:11 ` Alex Williamson
2012-05-15 2:03 ` David Gibson
2012-05-15 6:34 ` Alex Williamson
2012-05-17 3:29 ` David Gibson
2012-05-11 22:55 ` [Qemu-devel] [PATCH 03/13] iommu: IOMMU groups for VT-d and AMD-Vi Alex Williamson
2012-05-17 3:37 ` David Gibson
2012-05-11 22:55 ` [Qemu-devel] [PATCH 04/13] pci: New pci_dma_quirk() Alex Williamson
2012-05-17 3:39 ` David Gibson
2012-05-17 4:06 ` Alex Williamson
2012-05-17 7:19 ` Anonymous
2012-05-17 15:22 ` Alex Williamson
2012-05-11 22:56 ` [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled() Alex Williamson
2012-05-14 22:02 ` Bjorn Helgaas
2012-05-14 22:49 ` Alex Williamson
2012-05-15 19:56 ` Bjorn Helgaas
2012-05-15 20:05 ` Bjorn Helgaas
2012-05-15 21:09 ` Alex Williamson
2012-05-16 13:29 ` Don Dutile
2012-05-16 16:21 ` Alex Williamson
2012-05-16 19:36 ` Alex Williamson
2012-05-18 23:00 ` [Qemu-devel] RESEND3: " Don Dutile
2012-05-19 2:47 ` [Qemu-devel] " Alex Williamson
2012-05-21 13:31 ` Don Dutile
2012-05-21 14:59 ` Alex Williamson
2012-05-21 18:14 ` Don Dutile
2012-05-11 22:56 ` Alex Williamson [this message]
2012-05-11 22:56 ` [Qemu-devel] [PATCH 07/13] vfio: VFIO core Alex Williamson
2012-05-11 22:56 ` [Qemu-devel] [PATCH 08/13] vfio: Add documentation Alex Williamson
2012-05-11 22:56 ` [Qemu-devel] [PATCH 09/13] vfio: x86 IOMMU implementation Alex Williamson
2012-05-11 22:56 ` [Qemu-devel] [PATCH 10/13] pci: export pci_user functions for use by other drivers Alex Williamson
2012-05-14 21:20 ` Bjorn Helgaas
2012-05-11 22:56 ` [Qemu-devel] [PATCH 11/13] pci: Create common pcibios_err_to_errno Alex Williamson
2012-05-21 17:55 ` Konrad Rzeszutek Wilk
2012-05-11 22:56 ` [Qemu-devel] [PATCH 12/13] pci: Misc pci_reg additions Alex Williamson
2012-05-11 22:56 ` [Qemu-devel] [PATCH 13/13] vfio: Add PCI device driver Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511225609.30496.92191.stgit@bling.home \
--to=alex.williamson@redhat.com \
--cc=B07421@freescale.com \
--cc=B08248@freescale.com \
--cc=aafabbri@cisco.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=avi@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=benve@cisco.com \
--cc=bhelgaas@google.com \
--cc=chrisw@sous-sol.org \
--cc=david@gibson.dropbear.id.au \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).