From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STGsK-0005sI-0a for qemu-devel@nongnu.org; Sat, 12 May 2012 14:17:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STGsI-0002H5-7v for qemu-devel@nongnu.org; Sat, 12 May 2012 14:17:03 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:55088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STGsI-0002Gw-3r for qemu-devel@nongnu.org; Sat, 12 May 2012 14:17:02 -0400 Received: by qcsc20 with SMTP id c20so3022162qcs.4 for ; Sat, 12 May 2012 11:16:59 -0700 (PDT) Date: Sat, 12 May 2012 14:16:57 -0400 From: Kevin O'Connor Message-ID: <20120512181657.GA1550@morn.localdomain> References: <1336119687-6295-1-git-send-email-kraxel@redhat.com> <1336119687-6295-2-git-send-email-kraxel@redhat.com> <20120504131546.GA668@morn.localdomain> <4FA3F72E.7080103@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FA3F72E.7080103@redhat.com> Subject: Re: [Qemu-devel] [SeaBIOS] [seabios patch 1/5] pci: init all devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: seabios@seabios.org, qemu-devel@nongnu.org On Fri, May 04, 2012 at 05:35:10PM +0200, Gerd Hoffmann wrote: > On 05/04/12 15:15, Kevin O'Connor wrote: > > On Fri, May 04, 2012 at 10:21:23AM +0200, Gerd Hoffmann wrote: > >> seabios used to initialize root bus devices only, with this patch > >> devices behind pci bridges are initialized too. This allows to boot > >> from virtio devices behind pci bridges. > >> > >> Signed-off-by: Gerd Hoffmann > >> --- > >> src/pciinit.c | 3 --- > >> 1 files changed, 0 insertions(+), 3 deletions(-) > >> > >> diff --git a/src/pciinit.c b/src/pciinit.c > >> index 25b04ac..6a7a0d2 100644 > >> --- a/src/pciinit.c > >> +++ b/src/pciinit.c > >> @@ -213,9 +213,6 @@ static void pci_bios_init_devices(void) > >> { > >> struct pci_device *pci; > >> foreachpci(pci) { > >> - if (pci_bdf_to_bus(pci->bdf) != 0) > >> - // Only init devices on host bus. > >> - break; > > > > I think this will then assign an incorrect PCI_INTERRUPT_LINE value to > > non root bus devices. > > Attached patch should fix it if I read the specs correctly. I committed this patch. -Kevin