qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
	"Stefan Hajnoczi" <stefanha@linux.vnet.ibm.com>,
	gleb@redhat.com, "Marcelo Tosatti" <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"virt-devel@redhat.com" <virt-devel@redhat.com>,
	"Avi Kivity" <avi@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature
Date: Sun, 13 May 2012 15:02:58 +0300	[thread overview]
Message-ID: <20120513120258.GC24195@redhat.com> (raw)
In-Reply-To: <4FAD0A6F.5040002@redhat.com>

On Fri, May 11, 2012 at 06:47:43AM -0600, Eric Blake wrote:
> [adding libvirt, dropping kernel]
> 
> On 05/11/2012 01:43 AM, Michael S. Tsirkin wrote:
> > Whitelist kvm pv eoi feature. The feature is enabled
> > with -cpu kvm64. To disable: -cpu kvm64,-kvm_eoi.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > 
> > Sending a copy to kernel list as this is needed
> > to test the pv eoi feature recently submitted.
> > 
> >  target-i386/cpuid.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
> > index 465ea15..c421b19 100644
> > --- a/target-i386/cpuid.c
> > +++ b/target-i386/cpuid.c
> > @@ -75,7 +75,7 @@ static const char *ext3_feature_name[] = {
> >  };
> >  
> >  static const char *kvm_feature_name[] = {
> > -    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> > +    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_eoi", NULL,
> 
> Should libvirt also be recognizing this processor capability in its XML
> in order to drive the -kvm_eoi option?

I think so.

> -- 
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 

  reply	other threads:[~2012-05-13 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1336679924.git.mst@redhat.com>
2012-05-11  7:43 ` [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature Michael S. Tsirkin
2012-05-11 12:47   ` Eric Blake
2012-05-13 12:02     ` Michael S. Tsirkin [this message]
2012-05-13 12:05       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120513120258.GC24195@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=eblake@redhat.com \
    --cc=gleb@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=virt-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).