From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41118)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1STXW0-0001eR-V3
	for qemu-devel@nongnu.org; Sun, 13 May 2012 08:03:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1STXVw-0007Wj-Fz
	for qemu-devel@nongnu.org; Sun, 13 May 2012 08:03:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13178)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1STXVw-0007Wc-7q
	for qemu-devel@nongnu.org; Sun, 13 May 2012 08:03:04 -0400
Date: Sun, 13 May 2012 15:02:58 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120513120258.GC24195@redhat.com>
References: <20120511074334.GA1504@redhat.com>
 <4FAD0A6F.5040002@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FAD0A6F.5040002@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, gleb@redhat.com, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, "virt-devel@redhat.com" <virt-devel@redhat.com>, Avi Kivity <avi@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Fri, May 11, 2012 at 06:47:43AM -0600, Eric Blake wrote:
> [adding libvirt, dropping kernel]
> 
> On 05/11/2012 01:43 AM, Michael S. Tsirkin wrote:
> > Whitelist kvm pv eoi feature. The feature is enabled
> > with -cpu kvm64. To disable: -cpu kvm64,-kvm_eoi.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > 
> > Sending a copy to kernel list as this is needed
> > to test the pv eoi feature recently submitted.
> > 
> >  target-i386/cpuid.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
> > index 465ea15..c421b19 100644
> > --- a/target-i386/cpuid.c
> > +++ b/target-i386/cpuid.c
> > @@ -75,7 +75,7 @@ static const char *ext3_feature_name[] = {
> >  };
> >  
> >  static const char *kvm_feature_name[] = {
> > -    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> > +    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_eoi", NULL,
> 
> Should libvirt also be recognizing this processor capability in its XML
> in order to drive the -kvm_eoi option?

I think so.

> -- 
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>