* [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature
[not found] <cover.1336679924.git.mst@redhat.com>
@ 2012-05-11 7:43 ` Michael S. Tsirkin
2012-05-11 12:47 ` Eric Blake
0 siblings, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2012-05-11 7:43 UTC (permalink / raw)
To: x86, kvm
Cc: Anthony Liguori, Stefan Hajnoczi, gleb, Markus Armbruster,
Marcelo Tosatti, linux-kernel, qemu-devel, Ingo Molnar,
Avi Kivity, H. Peter Anvin, Linus Torvalds, Andreas Färber
Whitelist kvm pv eoi feature. The feature is enabled
with -cpu kvm64. To disable: -cpu kvm64,-kvm_eoi.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Sending a copy to kernel list as this is needed
to test the pv eoi feature recently submitted.
target-i386/cpuid.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index 465ea15..c421b19 100644
--- a/target-i386/cpuid.c
+++ b/target-i386/cpuid.c
@@ -75,7 +75,7 @@ static const char *ext3_feature_name[] = {
};
static const char *kvm_feature_name[] = {
- "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
+ "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_eoi", NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
--
MST
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature
2012-05-11 7:43 ` [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature Michael S. Tsirkin
@ 2012-05-11 12:47 ` Eric Blake
2012-05-13 12:02 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Eric Blake @ 2012-05-11 12:47 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Anthony Liguori, Stefan Hajnoczi, gleb, Marcelo Tosatti,
qemu-devel, Markus Armbruster, virt-devel@redhat.com, Avi Kivity,
Andreas Färber
[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]
[adding libvirt, dropping kernel]
On 05/11/2012 01:43 AM, Michael S. Tsirkin wrote:
> Whitelist kvm pv eoi feature. The feature is enabled
> with -cpu kvm64. To disable: -cpu kvm64,-kvm_eoi.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Sending a copy to kernel list as this is needed
> to test the pv eoi feature recently submitted.
>
> target-i386/cpuid.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
> index 465ea15..c421b19 100644
> --- a/target-i386/cpuid.c
> +++ b/target-i386/cpuid.c
> @@ -75,7 +75,7 @@ static const char *ext3_feature_name[] = {
> };
>
> static const char *kvm_feature_name[] = {
> - "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> + "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_eoi", NULL,
Should libvirt also be recognizing this processor capability in its XML
in order to drive the -kvm_eoi option?
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature
2012-05-11 12:47 ` Eric Blake
@ 2012-05-13 12:02 ` Michael S. Tsirkin
2012-05-13 12:05 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2012-05-13 12:02 UTC (permalink / raw)
To: Eric Blake
Cc: Anthony Liguori, Stefan Hajnoczi, gleb, Marcelo Tosatti,
qemu-devel, Markus Armbruster, virt-devel@redhat.com, Avi Kivity,
Andreas Färber
On Fri, May 11, 2012 at 06:47:43AM -0600, Eric Blake wrote:
> [adding libvirt, dropping kernel]
>
> On 05/11/2012 01:43 AM, Michael S. Tsirkin wrote:
> > Whitelist kvm pv eoi feature. The feature is enabled
> > with -cpu kvm64. To disable: -cpu kvm64,-kvm_eoi.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > Sending a copy to kernel list as this is needed
> > to test the pv eoi feature recently submitted.
> >
> > target-i386/cpuid.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
> > index 465ea15..c421b19 100644
> > --- a/target-i386/cpuid.c
> > +++ b/target-i386/cpuid.c
> > @@ -75,7 +75,7 @@ static const char *ext3_feature_name[] = {
> > };
> >
> > static const char *kvm_feature_name[] = {
> > - "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> > + "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_eoi", NULL,
>
> Should libvirt also be recognizing this processor capability in its XML
> in order to drive the -kvm_eoi option?
I think so.
> --
> Eric Blake eblake@redhat.com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature
2012-05-13 12:02 ` Michael S. Tsirkin
@ 2012-05-13 12:05 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2012-05-13 12:05 UTC (permalink / raw)
To: Eric Blake
Cc: Anthony Liguori, Stefan Hajnoczi, kvm, Marcelo Tosatti,
Markus Armbruster, gleb, qemu-devel, Avi Kivity,
Andreas Färber
On Sun, May 13, 2012 at 03:02:58PM +0300, Michael S. Tsirkin wrote:
> On Fri, May 11, 2012 at 06:47:43AM -0600, Eric Blake wrote:
> > [adding libvirt, dropping kernel]
> >
> > On 05/11/2012 01:43 AM, Michael S. Tsirkin wrote:
> > > Whitelist kvm pv eoi feature. The feature is enabled
> > > with -cpu kvm64. To disable: -cpu kvm64,-kvm_eoi.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > >
> > > Sending a copy to kernel list as this is needed
> > > to test the pv eoi feature recently submitted.
> > >
> > > target-i386/cpuid.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
> > > index 465ea15..c421b19 100644
> > > --- a/target-i386/cpuid.c
> > > +++ b/target-i386/cpuid.c
> > > @@ -75,7 +75,7 @@ static const char *ext3_feature_name[] = {
> > > };
> > >
> > > static const char *kvm_feature_name[] = {
> > > - "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> > > + "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_eoi", NULL,
> >
> > Should libvirt also be recognizing this processor capability in its XML
> > in order to drive the -kvm_eoi option?
>
> I think so.
A follow-up question: does libvirt use -cpu kvm?
How are such features normally handled for
cross-version migration?
> > --
> > Eric Blake eblake@redhat.com +1-919-301-3266
> > Libvirt virtualization library http://libvirt.org
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-13 12:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1336679924.git.mst@redhat.com>
2012-05-11 7:43 ` [Qemu-devel] [PATCH] qemu: whitelist kvm pv eoi feature Michael S. Tsirkin
2012-05-11 12:47 ` Eric Blake
2012-05-13 12:02 ` Michael S. Tsirkin
2012-05-13 12:05 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).