Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous

[Luiz Capitulino <lcapitulino@redhat.com>]

On Mon, 14 May 2012 12:19:04 -0500
Michael Roth <mdroth@linux.vnet.ibm.com> wrote:

> On Mon, May 14, 2012 at 01:39:50PM -0300, Luiz Capitulino wrote:
> > On Mon, 14 May 2012 09:56:30 -0500
> > Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
> > 
> > > Hi Luiz,
> > > 
> > > I have these patches applied to qga branch with Eric's suggested fix-ups included. I've attached them for your review. If all looks good I'll send a PULL some time today with what's hopefully all the pending fixes for qemu-ga 1.1
> > 
> > Yes, looks good. I was finishing to work on a similar version that moves
> > the loop to a function called ga_waitpid(), it's only missing some testing. But
> > you can merge this version if you're hurrying.
> > 
> > Btw, I have another fix that fixes guest-shutdown to use async-safe-signal
> > functions.
> > 
> > What's the best way to go? Do you want me to send just the guest-shutdown
> > fix or should I post my v2 of this series too (that uses ga_waitpid())?
> > 
> 
> Hmm, since Eric has already reviewed the quick fix let's just save ga_waitpid()
> for another day.

OK.

> Will keep an eye out for guest-shutdown fixes. I have a patch that
> switches it to using reopen_to_null() btw, but if that's already part of
> your patch I'll drop it in favor of yours:
> 
> https://github.com/mdroth/qemu/commits/qga

Yes, it's. Besides using reopen_to_null() we also have to switch to
execle() and _exit(). I'll give it a quick test and post it shortly.