From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STyvU-00078o-Pt for qemu-devel@nongnu.org; Mon, 14 May 2012 13:19:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STyvO-0003zl-Cw for qemu-devel@nongnu.org; Mon, 14 May 2012 13:19:16 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:37894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STyvO-0003z2-5f for qemu-devel@nongnu.org; Mon, 14 May 2012 13:19:10 -0400 Received: by obbwd20 with SMTP id wd20so9456136obb.4 for ; Mon, 14 May 2012 10:19:08 -0700 (PDT) Sender: fluxion Date: Mon, 14 May 2012 12:19:04 -0500 From: Michael Roth Message-ID: <20120514171904.GD28865@illuin> References: <1336763987-10920-1-git-send-email-lcapitulino@redhat.com> <1337007392-30304-1-git-send-email-mdroth@linux.vnet.ibm.com> <20120514133950.7e1492aa@doriath.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120514133950.7e1492aa@doriath.home> Subject: Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown & suspend synchronous List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: eblake@redhat.com, qemu-devel@nongnu.org On Mon, May 14, 2012 at 01:39:50PM -0300, Luiz Capitulino wrote: > On Mon, 14 May 2012 09:56:30 -0500 > Michael Roth wrote: > > > Hi Luiz, > > > > I have these patches applied to qga branch with Eric's suggested fix-ups included. I've attached them for your review. If all looks good I'll send a PULL some time today with what's hopefully all the pending fixes for qemu-ga 1.1 > > Yes, looks good. I was finishing to work on a similar version that moves > the loop to a function called ga_waitpid(), it's only missing some testing. But > you can merge this version if you're hurrying. > > Btw, I have another fix that fixes guest-shutdown to use async-safe-signal > functions. > > What's the best way to go? Do you want me to send just the guest-shutdown > fix or should I post my v2 of this series too (that uses ga_waitpid())? > Hmm, since Eric has already reviewed the quick fix let's just save ga_waitpid() for another day. Will keep an eye out for guest-shutdown fixes. I have a patch that switches it to using reopen_to_null() btw, but if that's already part of your patch I'll drop it in favor of yours: https://github.com/mdroth/qemu/commits/qga