Re: [Qemu-devel] [PATCH 1.1] linux-user: Fix stale tbs after mmap

[Riku Voipio <riku.voipio@iki.fi>]

On Tue, May 15, 2012 at 04:32:51PM -0500, Anthony Liguori wrote:
> Riku,
> 
> Can you review/ack this patch?

Acked-by: Riku Voipio <riku.voipio@linaro.org>

Are there any other Linux-user patches to consider for 1.1 ?

> 
> Regards,
> 
> Anthony Liguori
> 
> 
> On 05/15/2012 03:35 PM, Peter Maydell wrote:
> >Ping? This is 1.1 material in my opinion...
> >
> >(patchwork url: http://patchwork.ozlabs.org/patch/158556/)
> >
> >-- PMM
> >
> >On 11 May 2012 17:25, Peter Maydell<peter.maydell@linaro.org>  wrote:
> >>On 11 May 2012 09:40, Alexander Graf<agraf@suse.de>  wrote:
> >>>If we execute linux-user code that does the following:
> >>>
> >>>  * A = mmap()
> >>>  * execute code in A
> >>>  * munmap(A)
> >>>  * B = mmap(), but mmap returns the same address as A
> >>>  * execute code in B
> >>>
> >>>we end up executing a stale cached tb that contains translated code
> >>>from A, while we want new code from B.
> >>>
> >>>This patch adds a TB flush for mmap'ed regions, before we return them,
> >>>avoiding the whole issue. It also adds a flush for munmap, so that we
> >>>don't execute stale TBs instead of getting a segfault.
> >>>
> >>>Reported-by: Peter Maydell<peter.maydell@linaro.org>
> >>>Signed-off-by: Alexander Graf<agraf@suse.de>
> >>
> >>Reviewed-by: Peter Maydell<peter.maydell@linaro.org>
> >>
> >>-- PMM
> >