From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1SUgyQ-0007I2-PB
	for qemu-devel@nongnu.org; Wed, 16 May 2012 12:21:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1SUgyO-0007r5-O2
	for qemu-devel@nongnu.org; Wed, 16 May 2012 12:21:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13501)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1SUgyO-0007qd-G8
	for qemu-devel@nongnu.org; Wed, 16 May 2012 12:21:12 -0400
Date: Wed, 16 May 2012 17:20:59 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20120516162059.GQ22979@redhat.com>
References: <1337172904-20508-1-git-send-email-berrange@redhat.com>
	<4FB3CFFD.5090605@redhat.com> <4FB3D34E.2090802@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4FB3D34E.2090802@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] Add 'query-events' command to QMP to query
 async events
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Wed, May 16, 2012 at 11:18:22AM -0500, Anthony Liguori wrote:
> On 05/16/2012 11:04 AM, Eric Blake wrote:
> >On 05/16/2012 06:55 AM, Daniel P. Berrange wrote:
> >>From: "Daniel P. Berrange"<berrange@redhat.com>
> >>
> >>Sometimes it is neccessary for an application to determine
> >>whether a particular QMP event is available, so they can
> >>decide whether to use compatibility code instead. This
> >>introduces a new 'query-events' command to QMP todo just
> >
> >s/todo/to do/
> >
> >>that
> >>
> >>  { "execute": "query-events" }
> >>  {"return": [{"name": "WAKEUP"},
> >>              {"name": "SUSPEND"},
> >>              {"name": "DEVICE_TRAY_MOVED"},
> >>              {"name": "BLOCK_JOB_CANCELLED"},
> >>              {"name": "BLOCK_JOB_COMPLETED"},
> >>              ...snip...
> >>              {"name": "SHUTDOWN"}]}
> >>
> >>* monitor.c: Split out MonitorEvent ->  string conversion
> >>   into monitor_protocol_event_name() API. Add impl of
> >>   qmp_query_events monitor command handler
> >>* qapi-schema.json, qmp-commands.hx: Define contract of
> >>   query-events command
> >
> >Definitely useful for libvirt.
> >
> >
> >>+static const char *monitor_protocol_event_name(MonitorEvent event)
> >>+{
> >>      switch (event) {
> >>          case QEVENT_SHUTDOWN:
> >>-            event_name = "SHUTDOWN";
> >>+            return "SHUTDOWN";
> >>              break;
> >
> >These 'break' statements are now unreachable; does this matter in qemu
> >coding style?
> 
> Seems like we should just take the opportunity to kill off the
> function entirely and replace it with a table:
> 
> static const char *monitor_event_names[] = {
>  [QEVENT_SHUTDOWN] = "SHUTDOWN",
>  ...
> };

That sounds good to me, I'll update the patch accordingly.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|