From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47083)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SUh2y-0002sl-65
	for qemu-devel@nongnu.org; Wed, 16 May 2012 12:26:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SUh2s-00019Q-R8
	for qemu-devel@nongnu.org; Wed, 16 May 2012 12:25:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SUh2s-00018l-Jb
	for qemu-devel@nongnu.org; Wed, 16 May 2012 12:25:50 -0400
Date: Wed, 16 May 2012 19:25:44 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120516162544.GC10676@redhat.com>
References: <1337095599-28836-1-git-send-email-anthony.perard@citrix.com>
	<1337095599-28836-2-git-send-email-anthony.perard@citrix.com>
	<20120515205222.GA12039@redhat.com>
	<alpine.DEB.2.00.1205161124090.26786@kaball-desktop>
	<CAJJyHjKHn5HA6y0B8oHP7o2W=6_wd-0vpLzkeM74-ZYypn+tAA@mail.gmail.com>
	<4FB38E2E.5000508@redhat.com>
	<CAJJyHj+AOgGDUfKKkJa0R=kjokeN5dcz8yEXQPjnXsCrOQ52Dw@mail.gmail.com>
	<20120516132017.GB8620@redhat.com> <4FB3CD31.8050903@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FB3CD31.8050903@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force
	eject.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>, Xen Devel <xen-devel@lists.xen.org>, QEMU-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On Wed, May 16, 2012 at 05:52:17PM +0200, Paolo Bonzini wrote:
> Il 16/05/2012 15:20, Michael S. Tsirkin ha scritto:
> >>> Because it's missing the object_unparent done by qdev_unplug.  Does
> >>> object_unparent+qdev_free work?  (I believe object_unparent should be
> >>> done by qdev_free rather than qdev_unplug, but that's something for 1.2).
> >>
> >> Cool, this seems to work fine. Thanks.
> >>
> >> I'll test a bit more and resend a patch with only object_unparent+qdev_free.
> > 
> > Separately it was suggested to make qdev_free do object_unparent
> > automatically. Anthony is yet to respond.
> 
> Yes, but for 1.1 this Xen-only patch would be nice.
> 
> Paolo

No sure which this patch is meant, the force eject is not a good idea.
Freeing directly from Xen is fine.

-- 
MST