From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUrju-0007rh-EF for qemu-devel@nongnu.org; Wed, 16 May 2012 23:50:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUrjs-0002J8-Fi for qemu-devel@nongnu.org; Wed, 16 May 2012 23:50:58 -0400 Received: from ozlabs.org ([203.10.76.45]:34890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUrjs-0002Gk-5T for qemu-devel@nongnu.org; Wed, 16 May 2012 23:50:56 -0400 Date: Thu, 17 May 2012 13:37:14 +1000 From: David Gibson Message-ID: <20120517033714.GE22069@truffala.fritz.box> References: <20120511222148.30496.68571.stgit@bling.home> <20120511225548.30496.34428.stgit@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120511225548.30496.34428.stgit@bling.home> Subject: Re: [Qemu-devel] [PATCH 03/13] iommu: IOMMU groups for VT-d and AMD-Vi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: aafabbri@cisco.com, kvm@vger.kernel.org, B07421@freescale.com, aik@ozlabs.ru, konrad.wilk@oracle.com, linux-pci@vger.kernel.org, agraf@suse.de, qemu-devel@nongnu.org, chrisw@sous-sol.org, B08248@freescale.com, iommu@lists.linux-foundation.org, gregkh@linuxfoundation.org, avi@redhat.com, joerg.roedel@amd.com, bhelgaas@google.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org, benve@cisco.com On Fri, May 11, 2012 at 04:55:48PM -0600, Alex Williamson wrote: > Add back group support for AMD & Intel. amd_iommu already tracks > devices and has init and uninit routines to manage groups. > intel-iommu does this on the fly, so we make use of the notifier > support built into iommu groups to create and remove groups. Looks ok to me. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson