From: Alon Levy <alevy@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] Fix aml_name_string() to recognize block name modifiers.
Date: Sun, 20 May 2012 13:32:18 +0300 [thread overview]
Message-ID: <20120520103217.GD14484@garlic> (raw)
In-Reply-To: <1337504620-20378-1-git-send-email-gleb@redhat.com>
On Sun, May 20, 2012 at 12:03:38PM +0300, Gleb Natapov wrote:
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
> tools/acpi_extract.py | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/tools/acpi_extract.py b/tools/acpi_extract.py
> index 5f613e4..8038269 100755
> --- a/tools/acpi_extract.py
> +++ b/tools/acpi_extract.py
> @@ -121,7 +121,11 @@ def aml_name_string(offset):
> if (aml[offset] != 0x08):
> die( "Name offset 0x%x: expected 0x08 actual 0x%x" %
> (offset, aml[offset]));
> - return offset + 1;
> + offset += 1
> + # Block Name Modifier. Skip it.
> + if (aml[offset] == 0x5c or aml[offset] == 0x5e):
You don't need parenthesis around the whole conditional.
> + offset += 1
> + return offset;
>
> # Given data offset, find dword const offset
> def aml_data_dword_const(offset):
> --
> 1.7.7.3
>
>
> _______________________________________________
> SeaBIOS mailing list
> SeaBIOS@seabios.org
> http://www.seabios.org/mailman/listinfo/seabios
next prev parent reply other threads:[~2012-05-20 10:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 9:03 [Qemu-devel] [PATCH 1/3] Fix aml_name_string() to recognize block name modifiers Gleb Natapov
2012-05-20 9:03 ` [Qemu-devel] [PATCH 2/3] Add ACPI_EXTRACT_PKG_START macro parsing Gleb Natapov
2012-05-20 9:03 ` [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it Gleb Natapov
2012-05-20 11:44 ` Avi Kivity
2012-05-20 12:15 ` Gleb Natapov
2012-05-20 12:30 ` Avi Kivity
2012-05-20 12:36 ` Gleb Natapov
2012-05-20 12:47 ` Avi Kivity
2012-05-20 12:59 ` Gleb Natapov
2012-05-20 13:39 ` Avi Kivity
2012-05-20 13:57 ` Gleb Natapov
2012-05-20 14:34 ` Avi Kivity
2012-05-20 14:43 ` Gleb Natapov
2012-05-20 14:46 ` Avi Kivity
2012-05-20 15:15 ` Gleb Natapov
2012-05-20 16:16 ` Kevin O'Connor
2012-05-20 16:25 ` Avi Kivity
2012-05-20 16:39 ` Kevin O'Connor
2012-05-20 16:49 ` Gleb Natapov
2012-05-20 16:11 ` Kevin O'Connor
2012-05-20 10:32 ` Alon Levy [this message]
2012-05-20 11:13 ` [Qemu-devel] [SeaBIOS] [PATCH 1/3] Fix aml_name_string() to recognize block name modifiers Gleb Natapov
2012-05-23 1:23 ` [Qemu-devel] " Kevin O'Connor
2012-06-20 13:08 ` Gleb Natapov
2012-06-22 1:06 ` Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120520103217.GD14484@garlic \
--to=alevy@redhat.com \
--cc=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).