From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54403)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1SW44j-0007hX-GI
	for qemu-devel@nongnu.org; Sun, 20 May 2012 07:13:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1SW44h-0004wc-Jn
	for qemu-devel@nongnu.org; Sun, 20 May 2012 07:13:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5122)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1SW44h-0004wT-C8
	for qemu-devel@nongnu.org; Sun, 20 May 2012 07:13:23 -0400
Date: Sun, 20 May 2012 14:13:20 +0300
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20120520111320.GI10209@redhat.com>
References: <1337504620-20378-1-git-send-email-gleb@redhat.com>
	<20120520103217.GD14484@garlic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120520103217.GD14484@garlic>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] Fix aml_name_string() to
 recognize block name modifiers.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: seabios@seabios.org, qemu-devel@nongnu.org

On Sun, May 20, 2012 at 01:32:18PM +0300, Alon Levy wrote:
> On Sun, May 20, 2012 at 12:03:38PM +0300, Gleb Natapov wrote:
> > 
> > Signed-off-by: Gleb Natapov <gleb@redhat.com>
> > ---
> >  tools/acpi_extract.py |    6 +++++-
> >  1 files changed, 5 insertions(+), 1 deletions(-)
> > 
> > diff --git a/tools/acpi_extract.py b/tools/acpi_extract.py
> > index 5f613e4..8038269 100755
> > --- a/tools/acpi_extract.py
> > +++ b/tools/acpi_extract.py
> > @@ -121,7 +121,11 @@ def aml_name_string(offset):
> >      if (aml[offset] != 0x08):
> >          die( "Name offset 0x%x: expected 0x08 actual 0x%x" %
> >               (offset, aml[offset]));
> > -    return offset + 1;
> > +    offset += 1
> > +    # Block Name Modifier. Skip it.
> > +    if (aml[offset] == 0x5c or aml[offset] == 0x5e):
> 
> You don't need parenthesis around the whole conditional.
Rest of the code has it. Better to keep same style :)

> 
> > +        offset += 1
> > +    return offset;
> >  
> >  # Given data offset, find dword const offset
> >  def aml_data_dword_const(offset):
> > -- 
> > 1.7.7.3
> > 
> > 
> > _______________________________________________
> > SeaBIOS mailing list
> > SeaBIOS@seabios.org
> > http://www.seabios.org/mailman/listinfo/seabios

--
			Gleb.