From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWYdK-0002cc-4l for qemu-devel@nongnu.org; Mon, 21 May 2012 15:51:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWYdE-00058G-Ow for qemu-devel@nongnu.org; Mon, 21 May 2012 15:51:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWYdE-00057y-Gf for qemu-devel@nongnu.org; Mon, 21 May 2012 15:51:04 -0400 Date: Mon, 21 May 2012 20:50:55 +0100 From: "Daniel P. Berrange" Message-ID: <20120521195055.GX24629@redhat.com> References: <1337619593-25823-1-git-send-email-berrange@redhat.com> <1337619593-25823-3-git-send-email-berrange@redhat.com> <20120521194459.GE14541@amit.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20120521194459.GE14541@amit.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/3] Add event notification for guest balloon changes Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Markus Armbruster , qemu-devel@nongnu.org, Anthony Liguori , Luiz Capitulino On Tue, May 22, 2012 at 01:14:59AM +0530, Amit Shah wrote: > On (Mon) 21 May 2012 [17:59:52], Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > After setting a balloon target value, applications have to > > continually poll 'query-balloon' to determine whether the > > guest has reacted to this request. The virtio-balloon backend > > knows exactly when the guest has reacted though, and thus it > > is possible to emit a JSON event to tell the mgmt application > > whenever the guest balloon changes. > > > > This introduces a new 'qemu_balloon_change()' API which is > > I prefer qemu_balloon_changed(), it is clearer that this is called > after a balloon value change. qemu_balloon_change() can be taken to > mean the function is called as a response the the monitor 'balloon' > command. Happy to change this. > > +BALLOON_CHANGE > > +---------- > > similarly, this can be BALLOON_CHANGED For the sake of consistency with the existing RTC_CHANGE event, I prefer the naming I already have. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|