From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWoYI-0004bu-13 for qemu-devel@nongnu.org; Tue, 22 May 2012 08:51:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWoYB-0005vt-P6 for qemu-devel@nongnu.org; Tue, 22 May 2012 08:51:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWoYB-0005ug-5L for qemu-devel@nongnu.org; Tue, 22 May 2012 08:50:55 -0400 Date: Tue, 22 May 2012 18:20:49 +0530 From: Amit Shah Message-ID: <20120522125049.GA8828@amit.redhat.com> References: <1337619593-25823-1-git-send-email-berrange@redhat.com> <1337619593-25823-3-git-send-email-berrange@redhat.com> <20120521194459.GE14541@amit.redhat.com> <20120521195055.GX24629@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120521195055.GX24629@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/3] Add event notification for guest balloon changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Markus Armbruster , qemu-devel@nongnu.org, Anthony Liguori , Luiz Capitulino On (Mon) 21 May 2012 [20:50:55], Daniel P. Berrange wrote: > On Tue, May 22, 2012 at 01:14:59AM +0530, Amit Shah wrote: > > On (Mon) 21 May 2012 [17:59:52], Daniel P. Berrange wrote: > > > From: "Daniel P. Berrange" > > > > > > After setting a balloon target value, applications have to > > > continually poll 'query-balloon' to determine whether the > > > guest has reacted to this request. The virtio-balloon backend > > > knows exactly when the guest has reacted though, and thus it > > > is possible to emit a JSON event to tell the mgmt application > > > whenever the guest balloon changes. > > > > > > This introduces a new 'qemu_balloon_change()' API which is > > > > I prefer qemu_balloon_changed(), it is clearer that this is called > > after a balloon value change. qemu_balloon_change() can be taken to > > mean the function is called as a response the the monitor 'balloon' > > command. > > Happy to change this. > > > > +BALLOON_CHANGE > > > +---------- > > > > similarly, this can be BALLOON_CHANGED > > For the sake of consistency with the existing RTC_CHANGE event, I prefer > the naming I already have. OK, thinking about it, it seems alright for this to remain BALLOON_CHANGE, as it's an event that originates from qemu for mgmt apps, so there isn't ambiguity about it. Maybe others can chime in? Amit