From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXBmk-00045h-41 for qemu-devel@nongnu.org; Wed, 23 May 2012 09:39:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXBmc-0003C9-9A for qemu-devel@nongnu.org; Wed, 23 May 2012 09:39:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXBmc-0003Bs-0m for qemu-devel@nongnu.org; Wed, 23 May 2012 09:39:22 -0400 Date: Wed, 23 May 2012 10:33:50 -0300 From: Luiz Capitulino Message-ID: <20120523103350.33a5095b@doriath.home> In-Reply-To: <4FBC146B.6050801@linux.vnet.ibm.com> References: <1337631598-30639-1-git-send-email-coreyb@linux.vnet.ibm.com> <1337631598-30639-3-git-send-email-coreyb@linux.vnet.ibm.com> <20120522160606.05b3fb96@doriath.home> <4FBBF0CB.6070404@linux.vnet.ibm.com> <20120522172646.006012f2@doriath.home> <4FBC146B.6050801@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 2/4] qmp/hmp: Add getfd_file monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, eblake@redhat.com On Tue, 22 May 2012 18:34:19 -0400 Corey Bryant wrote: > On 05/22/2012 04:26 PM, Luiz Capitulino wrote: > > On Tue, 22 May 2012 16:02:19 -0400 > > Corey Bryant wrote: > > > >>> But there's a small problem. Today getfd commands are closely tied to the > >>> Monitor. In Anthony's development tree, the getfd commands are tied to the > >>> new QMP server's session support. > >>> > >>> Asking you to integrate the new QMP server only to have the getfd command > >>> returning a simple integer would be too much, but at the same time I think > >>> you'll have to at least to break it from the monitor. This means moving its > >>> data structure away from the Monitor object and probably reworking the > >>> internal API used to get fds (ie. monitor_get_fd()). > >>> > >>> Shouldn't be hard, but you should be careful not to break external users. > >>> > >> > >> Just to verify, are you talking about moving the "fds" off the Monitor > >> struct? --> QLIST_HEAD(,mon_fd_t) fds; > > > > Yes. > > > >> Was this already moved away from the Monitor struct in Anthony's > >> development tree? If not do you have a recommendation on where to move it? > > > > Yes, iirc it moved inside the new QMP server session support in Anthony's tree. > > > >> I think this would make more sense to me if I took a look at the getfd > >> code in Anthony's development tree. Is this the correct tree? I had > >> some issues cloning it. https://github.com/aliguori/qemu-next.git > > > > The 'development' tree I'm referring to is the old glib branch in > > git://repo.or.cz/qemu/aliguori.git. > > > > Hmm, it looks like fds is still on the Monitor struct in that branch. Oh, you're right. That code is unfinished. It seems that I kept the finished version in my mind. Well, I don't think that moving the fd array to another object will buy us much, so you can keep it this way. Note that you still have to convert do_getfd() to the QAPI as pointed out by Stefan and that the monitor object (*mon pointer) won't be passed to it. You'll have to use cur_mon in qmp_getfd() (as Anthony's version does).