Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current

[Luiz Capitulino <lcapitulino@redhat.com>]

On Wed, 23 May 2012 22:33:22 +0800
dunrong huang <riegamaths@gmail.com> wrote:

> 2012/5/23 Luiz Capitulino <lcapitulino@redhat.com>
> 
> > On Wed, 23 May 2012 10:35:36 +0800
> > dunrong huang <riegamaths@gmail.com> wrote:
> >
> > > 2012/5/23 Andreas Färber <afaerber@suse.de>
> > >
> > > > Am 23.05.2012 01:09, schrieb qemu@buildbot.b1-systems.de:
> > > > > The Buildbot has detected a new failure on builder
> > > > default_openbsd_current while building qemu.
> > > > > Full details are available at:
> > > > >
> > > >
> > http://buildbot.b1-systems.de/qemu/builders/default_openbsd_current/builds/271
> > > > >
> > > > > Buildbot URL: http://buildbot.b1-systems.de/qemu/
> > > > >
> > > > > Buildslave for this Build: brad_openbsd_current
> > > > >
> > > > > Build Reason: The Nightly scheduler named 'nightly_default' triggered
> > > > this build
> > > > > Build Source Stamp: [branch master] HEAD
> > > > > Blamelist:
> > > > >
> > > > > BUILD FAILED: failed compile
> > > >
> > > > qga/commands-posix.c: In function 'qmp_guest_shutdown':
> > > > qga/commands-posix.c:65: error: 'environ' undeclared (first use in this
> > > > function)
> > > >
> > > It seems like "extern char **environ;" is missing when building on
> > openbsd
> >
> > Heh, I thought this wouldn't happen. It has been discussed here:
> >
> >  http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg01905.html
> >
> 
> Do you mean
> 
> "What's the worst case if we leave it as is? The build will brake if environ
> ends up not being declared by some arch, right? In that case we could leave it
> as is and fix it when it brakes :)"

Yes, silly me :)

> Maybe we need a patch to declare environ for openbsd

Yes, I have the patch already but am installing openbsd on a VM to test it.