From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SXCfH-0007dD-IG
	for qemu-devel@nongnu.org; Wed, 23 May 2012 10:35:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SXCf6-000464-JD
	for qemu-devel@nongnu.org; Wed, 23 May 2012 10:35:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23051)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SXCf6-00045V-BW
	for qemu-devel@nongnu.org; Wed, 23 May 2012 10:35:40 -0400
Date: Wed, 23 May 2012 11:35:49 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120523113549.346baf42@doriath.home>
In-Reply-To: <CAOZVR5b9cgmPO45TNdAM47VuL6Hi237LFP9ey6rwAK-gamPibg@mail.gmail.com>
References: <20120522230955.5F24540404@buildbot.b1-systems.de>
	<4FBC242A.4080107@suse.de>
	<CAOZVR5bnLZZ5BvZ3KCuFennLROEg9v3m3aPtu8BaecvHCBmY8w@mail.gmail.com>
	<20120523103954.27b13af7@doriath.home>
	<CAOZVR5b9cgmPO45TNdAM47VuL6Hi237LFP9ey6rwAK-gamPibg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: dunrong huang <riegamaths@gmail.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, agraf@suse.de, qemu@buildbot.b1-systems.de, gollub@b1-systems.de, Eric Blake <eblake@redhat.com>, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Wed, 23 May 2012 22:33:22 +0800
dunrong huang <riegamaths@gmail.com> wrote:

> 2012/5/23 Luiz Capitulino <lcapitulino@redhat.com>
>=20
> > On Wed, 23 May 2012 10:35:36 +0800
> > dunrong huang <riegamaths@gmail.com> wrote:
> >
> > > 2012/5/23 Andreas F=E4rber <afaerber@suse.de>
> > >
> > > > Am 23.05.2012 01:09, schrieb qemu@buildbot.b1-systems.de:
> > > > > The Buildbot has detected a new failure on builder
> > > > default_openbsd_current while building qemu.
> > > > > Full details are available at:
> > > > >
> > > >
> > http://buildbot.b1-systems.de/qemu/builders/default_openbsd_current/bui=
lds/271
> > > > >
> > > > > Buildbot URL: http://buildbot.b1-systems.de/qemu/
> > > > >
> > > > > Buildslave for this Build: brad_openbsd_current
> > > > >
> > > > > Build Reason: The Nightly scheduler named 'nightly_default' trigg=
ered
> > > > this build
> > > > > Build Source Stamp: [branch master] HEAD
> > > > > Blamelist:
> > > > >
> > > > > BUILD FAILED: failed compile
> > > >
> > > > qga/commands-posix.c: In function 'qmp_guest_shutdown':
> > > > qga/commands-posix.c:65: error: 'environ' undeclared (first use in =
this
> > > > function)
> > > >
> > > It seems like "extern char **environ;" is missing when building on
> > openbsd
> >
> > Heh, I thought this wouldn't happen. It has been discussed here:
> >
> >  http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg01905.html
> >
>=20
> Do you mean
>=20
> "What's the worst case if we leave it as is? The build will brake if envi=
ron
> ends up not being declared by some arch, right? In that case we could lea=
ve it
> as is and fix it when it brakes :)"

Yes, silly me :)

> Maybe we need a patch to declare environ for openbsd

Yes, I have the patch already but am installing openbsd on a VM to test it.