From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41053)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SXCox-0003Wj-5V
	for qemu-devel@nongnu.org; Wed, 23 May 2012 10:45:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SXCop-0007YS-MO
	for qemu-devel@nongnu.org; Wed, 23 May 2012 10:45:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50761)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SXCop-0007Y4-7m
	for qemu-devel@nongnu.org; Wed, 23 May 2012 10:45:43 -0400
Date: Wed, 23 May 2012 17:45:33 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120523144532.GA30289@redhat.com>
References: <20120523135206.GA14654@chinaltcdragon.cn.ibm.com>
	<20120523141202.GC29930@redhat.com> <4FBCF46E.3020509@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FBCF46E.3020509@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Brian Zhao <zwanp@linux.vnet.ibm.com>, Kelvin Wang <senwang@linux.vnet.ibm.com>, Amos Kong <kongjianjun@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote:
> Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto:
> >> > 2, Run qemu with the option -monitor.
> >> > 
> >> > 3, In the guest, insert necessary modules:
> >> > for m in acpiphp pci_hotplug; do sudo modprobe ${m}; done
> >> > 
> >> > 4, In the qemu monitor,hot add a virtio-scsi-pci adapter:
> >> > (qemu)pci_add auto storage if=virtio-scsi-pci
> >> > 
> >> > 5, Check whether the controller was added:
> >> > Guest: lspci
> >> > Qemu: (qemu)info qtree
> >> > 
> >> > Signed-off-by: Kelvin Wang <senwang@linux.vnet.ibm.com>
> >> > Signed-off-by: Sheng Liu <liusheng@linux.vnet.ibm.com>
> > NAK
> > 
> > Do not use pci_add. It is a compatibility command.
> > Use the new style device_add.
> > Same for if=.
> > 
> > I think you won't need any changes then?
> > 
> 
> You don't.  You need to rescan the bus manually in the guest, that's all.
> 
> Paolo

If the point is to avoid need for manual bus rescans that's
good. But please do not touch the legacy commands.
If anyone wants to use new devices, new commands
drive_add and device_add should be used.
Same for command line flags.

-- 
MST