From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXJ45-0000hQ-R8 for qemu-devel@nongnu.org; Wed, 23 May 2012 17:25:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXJ44-0000YL-36 for qemu-devel@nongnu.org; Wed, 23 May 2012 17:25:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXJ43-0000Y1-QM for qemu-devel@nongnu.org; Wed, 23 May 2012 17:25:52 -0400 Date: Wed, 23 May 2012 18:25:36 -0300 From: Luiz Capitulino Message-ID: <20120523182536.687fcae8@doriath.home> In-Reply-To: <20120523200843.GB2916@illuin> References: <1337798885-23070-1-git-send-email-lcapitulino@redhat.com> <20120523200843.GB2916@illuin> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de, kraxel@redhat.com On Wed, 23 May 2012 15:08:43 -0500 Michael Roth wrote: > On Wed, May 23, 2012 at 03:48:03PM -0300, Luiz Capitulino wrote: > > Build error found by buildbot: > > > > qga/commands-posix.c: In function 'qmp_guest_shutdown': > > qga/commands-posix.c:65: error: 'environ' undeclared (first use in this function) > > qga/commands-posix.c:65: error: (Each undeclared identifier is reported only once > > qga/commands-posix.c:65: error: for each function it appears in.) > > > > On F16 environ is declared in , but that obviously doesn't > > happen on all systems. > > > > Tested on OpenBSD 4.9. Just tested on 5.1 too. > > PS: I get zillions of -Wno-redundant-decls errors on OpenBSD 4.8 and still > > get other warnnigs if I drop that flag. All the -Wno-redundant-decls warnings are still there on 5.1, if I remove that flag I still get the following ones. Michael, do you want me to fix the qemu-ga one for 1.1? LINK qemu-ga /usr/local/lib/libglib-2.0.so.2992.0: warning: vsprintf() is often misused, please use vsnprintf() /usr/local/lib/libglib-2.0.so.2992.0: warning: stpcpy() is dangerous GNU crap; don't use it /usr/local/lib/libglib-2.0.so.2992.0: warning: strcpy() is almost always misused, please use strlcpy() qemu-ga.o(.text+0x358): In function `ga_open_pidfile': /home/lcapitulino/qmp-unstable/qemu-ga.c:258: warning: sprintf() is often misused, please use snprintf()