From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org,
afaerber@suse.de, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd
Date: Wed, 23 May 2012 15:08:43 -0500 [thread overview]
Message-ID: <20120523200843.GB2916@illuin> (raw)
In-Reply-To: <1337798885-23070-1-git-send-email-lcapitulino@redhat.com>
On Wed, May 23, 2012 at 03:48:03PM -0300, Luiz Capitulino wrote:
> Build error found by buildbot:
>
> qga/commands-posix.c: In function 'qmp_guest_shutdown':
> qga/commands-posix.c:65: error: 'environ' undeclared (first use in this function)
> qga/commands-posix.c:65: error: (Each undeclared identifier is reported only once
> qga/commands-posix.c:65: error: for each function it appears in.)
>
> On F16 environ is declared in <unistd.h>, but that obviously doesn't
> happen on all systems.
>
> Tested on OpenBSD 4.9.
>
> PS: I get zillions of -Wno-redundant-decls errors on OpenBSD 4.8 and still
> get other warnnigs if I drop that flag.
>
> configure | 19 +++++++++++++++++++
> qga/commands-posix.c | 6 +++++-
> 2 files changed, 24 insertions(+), 1 deletion(-)
>
Thanks, applied to qga branch. Will send a 1.1 pull request for these.
next prev parent reply other threads:[~2012-05-23 20:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 18:48 [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd Luiz Capitulino
2012-05-23 18:48 ` [Qemu-devel] [PATCH 1/2] configure: check if environ is declared Luiz Capitulino
2012-05-23 18:48 ` [Qemu-devel] [PATCH 2/2] qemu-ga: Fix missing environ declaration Luiz Capitulino
2012-05-23 20:08 ` Michael Roth [this message]
2012-05-23 21:25 ` [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd Luiz Capitulino
2012-05-23 22:02 ` Michael Roth
2012-05-23 22:15 ` Andreas Färber
2012-05-23 22:57 ` Michael Roth
2012-05-23 23:07 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523200843.GB2916@illuin \
--to=mdroth@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).