From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41522)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SXHrY-00074w-3J
	for qemu-devel@nongnu.org; Wed, 23 May 2012 16:08:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SXHrW-0000wP-Ak
	for qemu-devel@nongnu.org; Wed, 23 May 2012 16:08:51 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:51653)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1SXHrW-0000vb-3a
	for qemu-devel@nongnu.org; Wed, 23 May 2012 16:08:50 -0400
Received: by obbwd20 with SMTP id wd20so14300829obb.4
	for <qemu-devel@nongnu.org>; Wed, 23 May 2012 13:08:48 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 23 May 2012 15:08:43 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120523200843.GB2916@illuin>
References: <1337798885-23070-1-git-send-email-lcapitulino@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1337798885-23070-1-git-send-email-lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de, kraxel@redhat.com

On Wed, May 23, 2012 at 03:48:03PM -0300, Luiz Capitulino wrote:
> Build error found by buildbot:
> 
>  qga/commands-posix.c: In function 'qmp_guest_shutdown':
>  qga/commands-posix.c:65: error: 'environ' undeclared (first use in this function)
>  qga/commands-posix.c:65: error: (Each undeclared identifier is reported only once
>  qga/commands-posix.c:65: error: for each function it appears in.)
> 
> On F16 environ is declared in <unistd.h>, but that obviously doesn't
> happen on all systems.
> 
> Tested on OpenBSD 4.9.
> 
> PS: I get zillions of -Wno-redundant-decls errors on OpenBSD 4.8 and still
>     get other warnnigs if I drop that flag.
> 
>  configure            |   19 +++++++++++++++++++
>  qga/commands-posix.c |    6 +++++-
>  2 files changed, 24 insertions(+), 1 deletion(-)
> 

Thanks, applied to qga branch. Will send a 1.1 pull request for these.