From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1SXahb-00041V-D5
	for qemu-devel@nongnu.org; Thu, 24 May 2012 12:15:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1SXahV-0002b2-6r
	for qemu-devel@nongnu.org; Thu, 24 May 2012 12:15:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31883)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1SXahU-0002aC-UP
	for qemu-devel@nongnu.org; Thu, 24 May 2012 12:15:45 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4OGFh4C002422
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 24 May 2012 12:15:43 -0400
Date: Thu, 24 May 2012 19:15:37 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120524161537.GR6105@garlic.tlv.redhat.com>
References: <4FBDF65F.8070609@redhat.com>
	<1337852294-12224-1-git-send-email-alevy@redhat.com>
	<1337852294-12224-3-git-send-email-alevy@redhat.com>
	<4FBE3080.9040201@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FBE3080.9040201@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, May 24, 2012 at 02:58:40PM +0200, Gerd Hoffmann wrote:
> On 05/24/12 11:38, Alon Levy wrote:
> > For all devices print id, mode and guest_bug status.
> 
> Queued up 1+2+4

Please unqueue "qxl: stop dirty loging when not in vga mode" and I'll
send it again with the separate patch "hw/qxl: ignore guest from
guestbug until reset" that accidentally got squashed into it.

> 
> For this one I wanna have an additional ack from qmp camp.
> Also a nit:
> 
> >  # @SpiceInfo
> >  #
> >  # Information about the SPICE session.
> > @@ -683,12 +721,17 @@
> >  #
> >  # @channels: a list of @SpiceChannel for each active spice channel
> >  #
> > +# @qxl0_mode: Mode of the primary qxl device.
> > +#
> > +# @qxl0_guest_bug: Guest bug status of primary qxl device.
> > +#
> 
> Code changed, but docs didn't ...
> 
> Otherwise looks fine to me.
> 
> cheers,
>   Gerd
>