From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] qemu_find_file: check name as a straight path even if it has no '/'
Date: Fri, 25 May 2012 14:23:28 +0200 [thread overview]
Message-ID: <20120525122328.GA9298@edde.se.axis.com> (raw)
In-Reply-To: <4FBF7963.1070604@suse.de>
On Fri, May 25, 2012 at 02:21:55PM +0200, Andreas Färber wrote:
> Am 25.05.2012 14:07, schrieb Peter Maydell:
> > Make qemu_find_file() check for the passed in name as a straight
> > pathname even if it doesn't have any path separator character in it.
> > This means that "-bios foo", "-dtb foo" etc will find a file 'foo'
> > in the current directory.
> > This removes an inconsistency with -kernel and -initrd, which both
> > accept plain filenames as meaning files in the current directory.
> > It's also less confusing for the user than an undocumented restriction
> > that "this option accepts a filename, except for the special case
> > where the filename you pass happens not to have a '/' in it, in
> > which case we'll ignore it."
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Speaking of inconsistencies, I also noticed that the ppc virtex-ml507
> machine relies on the .dtb being in the current directory with
> apparently no way to override. Any chance this can be fixed, Edgar?
> Maybe it can be unified with the dtb handling on ARM or share the same
> QemuOpts?
Yes, absolutely!
Best regards,
Edgar
next prev parent reply other threads:[~2012-05-25 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 12:07 [Qemu-devel] [PATCH] qemu_find_file: check name as a straight path even if it has no '/' Peter Maydell
2012-05-25 12:21 ` Andreas Färber
2012-05-25 12:23 ` Edgar E. Iglesias [this message]
2012-06-19 15:13 ` Peter Maydell
[not found] ` <CAFEAcA9KHcJjrK7pzTd7Pexi1Sq46V1DOosoGPS4XxiF2si-yQ@mail.gmail.com>
2012-07-10 14:18 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120525122328.GA9298@edde.se.axis.com \
--to=edgar.iglesias@gmail.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).