From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYvmA-0005nu-MW for qemu-devel@nongnu.org; Mon, 28 May 2012 04:58:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYvm5-0003Uo-Tm for qemu-devel@nongnu.org; Mon, 28 May 2012 04:58:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYvm5-0003Uf-MM for qemu-devel@nongnu.org; Mon, 28 May 2012 04:58:01 -0400 Date: Mon, 28 May 2012 11:57:46 +0300 From: Alon Levy Message-ID: <20120528085746.GB8353@garlic> References: <1337974879-3656-1-git-send-email-lcapitulino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337974879-3656-1-git-send-email-lcapitulino@redhat.com> Subject: Re: [Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com On Fri, May 25, 2012 at 04:41:05PM -0300, Luiz Capitulino wrote: > Converting the screendump command is simple and shouldn't take more than > or or two patches, the complicated part is to report all errors correctly. > > I hope I didn't go too far there, but at least this series does the right > thing (or is very near to). > Reviewed-by: Alon Levy > console.c | 7 ++-- > console.h | 5 +-- > cutils.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > hmp-commands.hx | 5 ++- > hmp.c | 9 +++++ > hmp.h | 1 + > hw/blizzard.c | 4 +-- > hw/g364fb.c | 51 ++++++++++++++++++++-------- > hw/omap_lcdc.c | 60 +++++++++++++++++++++++---------- > hw/qxl.c | 7 ++-- > hw/tcx.c | 96 ++++++++++++++++++++++++++++++++++++++++------------ > hw/vga.c | 38 +++++++++++++-------- > hw/vga_int.h | 3 +- > hw/vmware_vga.c | 7 ++-- > monitor.c | 6 ---- > qapi-schema.json | 24 +++++++++++++ > qemu-common.h | 7 ++++ > qerror.c | 28 ++++++++++++++-- > qerror.h | 22 ++++++++++-- > qmp-commands.hx | 5 +-- > 20 files changed, 390 insertions(+), 95 deletions(-)