From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYxwp-0003vh-SD for qemu-devel@nongnu.org; Mon, 28 May 2012 07:17:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYxwo-0002OF-4p for qemu-devel@nongnu.org; Mon, 28 May 2012 07:17:15 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:56998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYxwn-0002Lr-SD for qemu-devel@nongnu.org; Mon, 28 May 2012 07:17:14 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 28 May 2012 12:17:07 +0100 Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4SBH5lA2797618 for ; Mon, 28 May 2012 12:17:05 +0100 Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4SBH5Rc027954 for ; Mon, 28 May 2012 05:17:05 -0600 Date: Mon, 28 May 2012 12:17:04 +0100 From: Stefan Hajnoczi Message-ID: <20120528111704.GD30438@stefanha-thinkpad.localdomain> References: <4FBF822D.9090707@redhat.com> <20120525100746.51d7bf28@doriath.home> <4FBF85BF.6050403@redhat.com> <20120525101830.1793d300@doriath.home> <4FBF86E0.7070908@redhat.com> <20120525103004.23cfc4f4@doriath.home> <4FBF8B0B.1090601@redhat.com> <20120525104322.2da0b0ba@doriath.home> <4FBF8D70.1030304@redhat.com> <20120525105628.1a1f3f8d@doriath.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120525105628.1a1f3f8d@doriath.home> Subject: Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kvm@vger.kernel.org, jan.kiszka@siemens.com, qemu-devel@nongnu.org, Markus Armbruster , zwu.kernel@gmail.com, wuzhy@linux.vnet.ibm.com, Stefan Hajnoczi , Paolo Bonzini On Fri, May 25, 2012 at 10:56:28AM -0300, Luiz Capitulino wrote: > On Fri, 25 May 2012 15:47:28 +0200 > Paolo Bonzini wrote: > > > Il 25/05/2012 15:43, Luiz Capitulino ha scritto: > > >> Yeah, VDE probably includes something like an hub. But then we could > > >> drop even "-net socket", "-net udp", "-net dump", and only leave in > > >> vde+tap+slirp. Or even move slirp into VDE. :) That's a very different > > >> thing. > > > > > > Let's start with what is hurting us. > > > > But is it? The patch makes it quite clean. > > vlan is and the cleanest solution is to drop it. For the sake of the argument, here's what we'd need: 1. Patches to remove vlan completely from QEMU. 2. net/dump.c alternative. Packet capture could be done like this: -netdev tap,dump=capture.pcap,... You specify the "dump" option on a netdev giving a filename to use for the pcap file. The net/dump.c would need to be called from net.c or maybe net/queue.c. What we need to decide is whether it's okay to drop QEMU "VLANs" completely and change dump command-line syntax? I think vlan-hub doesn't hurt anyone because the code has been isolated and we keep backwards compatibility. So I'd personally still go the vlan-hub route for QEMU 1.x. Stefan