From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SaUM4-0003nn-DE for qemu-devel@nongnu.org; Fri, 01 Jun 2012 12:05:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SaUM2-0008K2-Hb for qemu-devel@nongnu.org; Fri, 01 Jun 2012 12:05:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SaUM2-0008Jt-8T for qemu-devel@nongnu.org; Fri, 01 Jun 2012 12:05:34 -0400 Date: Fri, 1 Jun 2012 19:05:33 +0300 From: "Michael S. Tsirkin" Message-ID: <20120601160533.GC23768@redhat.com> References: <20120530193034.GE1551@redhat.com> <4FC681B4.3030807@web.de> <20120530203119.GH1551@redhat.com> <4FC8BB28.8000004@siemens.com> <20120601132745.GA21451@redhat.com> <4FC8CA2D.9060001@siemens.com> <20120601143413.GA22754@redhat.com> <4FC8DC9E.7060105@siemens.com> <20120601152851.GA23768@redhat.com> <4FC8E5A7.2000001@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FC8E5A7.2000001@siemens.com> Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Alex Williamson , Marcelo Tosatti , qemu-devel , Avi Kivity On Fri, Jun 01, 2012 at 05:54:15PM +0200, Jan Kiszka wrote: > On 2012-06-01 17:28, Michael S. Tsirkin wrote: > >>> So I won't object to adding a new API but if we do > >>> it properly this won't help compatibility :( > >> > >> It will as this API does not touch the parts that affect the vmstate > >> (ie. semantics of irq_count won't change). > > > > Yes but irq_count in vmstate is a bug. IMO even if we do > > not change anything we should ignore irq_count on > > load and recalculate it from what the devices supply. > > I don't disagree. But this will only allow keeping backward migration > support if we preserve the semantics of current map_irq somewhere - to > keep the chance of calculating the legacy values for vmsave as well. > > Jan We don't need to preserve it, right? We can calculate it before savevm. > -- > Siemens AG, Corporate Technology, CT T DE IT 1 > Corporate Competence Center Embedded Linux