From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 7/7] esp: add AMD PCscsi emulation (PCI SCSI adapter)
Date: Sun, 3 Jun 2012 14:23:43 +0300 [thread overview]
Message-ID: <20120603112342.GE3640@redhat.com> (raw)
In-Reply-To: <4FCB47E5.9080502@reactos.org>
On Sun, Jun 03, 2012 at 01:17:57PM +0200, Hervé Poussineau wrote:
> >It is better to prefix all global scope symbols with
> >esp_ consistently. Reduces the chance of a conflict.
>
> All these functions are local to the file. I'll change that to
> pci_esp_... like other PCI-related functions in this file.
esp_pci would be clearer and preferable.
> >
> >>+static void pci_esp_dma_write(PCIESPState *pci, uint32_t saddr, uint32_t val)
> >>+{
> >>+ trace_esp_pci_dma_write(saddr, pci->dma_regs[saddr], val);
> >>+ switch (saddr) {
> >>+ case DMA_CMD:
> >>+ pci->dma_regs[saddr] = val;
> >>+ switch (val & DMA_CMD_MASK) {
> >>+ case 0x0: /* IDLE */
> >>+ trace_esp_pci_dma_idle(val);
> >>+ break;
> >>+ case 0x1: /* BLAST */
> >>+ pci_handle_blast(pci, val);
> >
> >fall-through intentional?
>
> Not at all. Thanks.
>
> Hervé
prev parent reply other threads:[~2012-06-03 11:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 10:38 [Qemu-devel] [PATCH 0/7] esp: add AMD PCscsi emulation Hervé Poussineau
2012-06-03 10:38 ` [Qemu-devel] [PATCH 1/7] esp: implement Disable selection command Hervé Poussineau
2012-06-03 10:38 ` [Qemu-devel] [PATCH 2/7] esp: implement Reset ATN command Hervé Poussineau
2012-06-03 10:38 ` [Qemu-devel] [PATCH 3/7] esp: support future change of chip_id Hervé Poussineau
2012-06-03 10:38 ` [Qemu-devel] [PATCH 4/7] esp: use hba_private field instead of a complex cast Hervé Poussineau
2012-06-03 10:38 ` [Qemu-devel] [PATCH 5/7] esp: split esp code into generic chip emulation and sysbus layer Hervé Poussineau
2012-06-03 10:38 ` [Qemu-devel] [PATCH 6/7] esp: use error_report()/hw_error() instead of stderr output Hervé Poussineau
2012-06-03 10:38 ` [Qemu-devel] [PATCH 7/7] esp: add AMD PCscsi emulation (PCI SCSI adapter) Hervé Poussineau
2012-06-03 10:46 ` Michael S. Tsirkin
2012-06-03 11:17 ` Hervé Poussineau
2012-06-03 11:23 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120603112342.GE3640@redhat.com \
--to=mst@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=hpoussin@reactos.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).