From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Sb8uQ-0001oQ-OU
	for qemu-devel@nongnu.org; Sun, 03 Jun 2012 07:23:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Sb8uP-0004SP-3U
	for qemu-devel@nongnu.org; Sun, 03 Jun 2012 07:23:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12622)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Sb8uO-0004SA-Rd
	for qemu-devel@nongnu.org; Sun, 03 Jun 2012 07:23:45 -0400
Date: Sun, 3 Jun 2012 14:23:43 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120603112342.GE3640@redhat.com>
References: <1338719890-9935-1-git-send-email-hpoussin@reactos.org>
	<1338719890-9935-8-git-send-email-hpoussin@reactos.org>
	<20120603104648.GD3640@redhat.com> <4FCB47E5.9080502@reactos.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <4FCB47E5.9080502@reactos.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 7/7] esp: add AMD PCscsi emulation (PCI
	SCSI adapter)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

On Sun, Jun 03, 2012 at 01:17:57PM +0200, Herv=E9 Poussineau wrote:
> >It is better to prefix all global scope symbols with
> >esp_ consistently. Reduces the chance of a conflict.
>=20
> All these functions are local to the file. I'll change that to
> pci_esp_... like other PCI-related functions in this file.

esp_pci would be clearer and preferable.

> >
> >>+static void pci_esp_dma_write(PCIESPState *pci, uint32_t saddr, uint=
32_t val)
> >>+{
> >>+    trace_esp_pci_dma_write(saddr, pci->dma_regs[saddr], val);
> >>+    switch (saddr) {
> >>+    case DMA_CMD:
> >>+        pci->dma_regs[saddr] =3D val;
> >>+        switch (val & DMA_CMD_MASK) {
> >>+        case 0x0: /* IDLE */
> >>+            trace_esp_pci_dma_idle(val);
> >>+            break;
> >>+        case 0x1: /* BLAST */
> >>+            pci_handle_blast(pci, val);
> >
> >fall-through intentional?
>=20
> Not at all. Thanks.
>=20
> Herv=E9