From: Luiz Capitulino <lcapitulino@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm@vger.kernel.org, Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
zwu.kernel@gmail.com, wuzhy@linux.vnet.ibm.com,
jan.kiszka@siemens.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking
Date: Mon, 4 Jun 2012 10:09:13 -0300 [thread overview]
Message-ID: <20120604100913.1c2aa845@doriath.home> (raw)
In-Reply-To: <4FCC4009.9060907@codemonkey.ws>
On Mon, 04 Jun 2012 12:56:41 +0800
Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 05/25/2012 08:53 PM, Luiz Capitulino wrote:
> > On Fri, 25 May 2012 13:01:37 +0100
> > Stefan Hajnoczi<stefanha@gmail.com> wrote:
> >
> >> I agree it would be nice to drop entirely but I don't feel happy doing
> >> that to users who might have QEMU buried in scripts somewhere. One
> >> day they upgrade packages and suddenly their stuff doesn't work
> >> anymore.
> >
> > This is very similar to kqemu and I don't think we regret having dropped it.
>
> You couldn't imagine the number of complaints I got from users about dropping
> kqemu. It caused me considerable pain. Complaints ranged from down right
> hostile (I had to involve the Launchpad admins at one point because of a
> particular user) to entirely sympathetic.
>
> kqemu wasn't just a maintenance burden, it was preventing large guest memory
> support in KVM guests. There was no simple way around it without breaking kqemu
> ABI and making significant changes to the kqemu module.
>
> Dropping features is only something that should be approached lightly and
> certainly not something that should be done just because you don't like a
> particular bit of code.
It's not just because I don't like the code. Afaik, there are better external
tools that seem to do exact the same thing (and even seem to do it better)
But as Markus said in the other thread, it's just advice, not strong objection.
prev parent reply other threads:[~2012-06-04 13:10 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 17:59 [Qemu-devel] [PATCH v3 00/16] net: hub-based networking zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 01/16] net: Add a hub net client zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 02/16] net: Use hubs for the vlan feature zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 03/16] net: Look up 'vlan' net clients using hubs zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 04/16] hub: Check that hubs are configured correctly zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 05/16] net: Drop vlan argument to qemu_new_net_client() zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 06/16] net: Remove vlan qdev property zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 07/16] net: Remove vlan code from net.c zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 08/16] net: Remove VLANState zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 09/16] net: Rename non_vlan_clients to net_clients zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 10/16] net: Rename VLANClientState to NetClientState zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 11/16] net: Rename vc local variables to nc zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 12/16] net: Rename qemu_del_vlan_client() to qemu_del_net_client() zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 13/16] net: Make the monitor output more reasonable hub info zwu.kernel
2012-05-24 20:34 ` Jan Kiszka
2012-05-25 0:48 ` Zhi Yong Wu
2012-05-25 12:00 ` Zhi Yong Wu
2012-05-25 13:49 ` Jan Kiszka
2012-05-25 13:58 ` Zhi Yong Wu
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 14/16] net: cleanup deliver/deliver_iov func pointers zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 15/16] net: determine if packets can be sent before net queue deliver packets zwu.kernel
2012-05-24 17:59 ` [Qemu-devel] [PATCH v3 16/16] hub: add the support for hub own flow control zwu.kernel
2012-05-25 7:04 ` Paolo Bonzini
2012-05-25 7:48 ` Zhi Yong Wu
2012-05-25 10:08 ` Paolo Bonzini
2012-05-25 10:54 ` Zhi Yong Wu
2012-05-25 8:04 ` Zhi Yong Wu
2012-05-25 8:18 ` Zhi Yong Wu
2012-05-24 20:53 ` [Qemu-devel] [PATCH v3 00/16] net: hub-based networking Luiz Capitulino
2012-05-25 0:47 ` Zhi Yong Wu
2012-05-25 12:49 ` Luiz Capitulino
2012-05-25 10:07 ` Stefan Hajnoczi
2012-05-25 11:18 ` Markus Armbruster
2012-05-25 12:01 ` Stefan Hajnoczi
2012-05-25 12:30 ` Markus Armbruster
2012-05-25 12:53 ` Luiz Capitulino
2012-05-25 12:59 ` Paolo Bonzini
2012-05-25 13:07 ` Luiz Capitulino
2012-05-25 13:14 ` Paolo Bonzini
2012-05-25 13:18 ` Luiz Capitulino
2012-05-25 13:19 ` Paolo Bonzini
2012-05-25 13:30 ` Luiz Capitulino
2012-05-25 13:37 ` Paolo Bonzini
2012-05-25 13:43 ` Luiz Capitulino
2012-05-25 13:47 ` Paolo Bonzini
2012-05-25 13:56 ` Luiz Capitulino
2012-05-28 11:17 ` Stefan Hajnoczi
2012-05-28 13:25 ` Luiz Capitulino
[not found] ` <m3ehq3tne0.fsf@blackfin.pond.sub.org>
2012-06-04 4:48 ` Anthony Liguori
2012-06-04 7:24 ` Markus Armbruster
2012-06-04 4:56 ` Anthony Liguori
2012-06-04 13:09 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120604100913.1c2aa845@doriath.home \
--to=lcapitulino@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).