From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sbdh3-0001cJ-TY for qemu-devel@nongnu.org; Mon, 04 Jun 2012 16:16:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sbdh2-0008F3-AE for qemu-devel@nongnu.org; Mon, 04 Jun 2012 16:16:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sbdh2-0008Ew-2N for qemu-devel@nongnu.org; Mon, 04 Jun 2012 16:16:00 -0400 Date: Mon, 4 Jun 2012 16:15:56 -0400 From: Jason Baron Message-ID: <20120604201556.GA2594@redhat.com> References: <20120511145725.16518.77110.stgit@t> <1337507865-28504-1-git-send-email-kongjianjun@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337507865-28504-1-git-send-email-kongjianjun@gmail.com> Subject: Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mst@redhat.com On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote: > Start VM with 8 multiple-function block devs, hot-removing > those block devs by 'device_del ...' would cause qemu abort. > > | (qemu) device_del virti0-0-0 > | (qemu) ** > |ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0) > > It's a regression introduced by commit 57c9fafe > I found a similar assertion where the parent reference isn't cleared, doing: (qemu) device_add pci-bridge in the monitor. I posted for patches for it under: Subject: [Qemu-devel] [PATCH 0/2] pci: hotplug bridge fixes It's still an issue with the current tree. Thanks, -Jason