From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sbf7l-0005Uy-R7 for qemu-devel@nongnu.org; Mon, 04 Jun 2012 17:47:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sbf7j-0006Fz-RZ for qemu-devel@nongnu.org; Mon, 04 Jun 2012 17:47:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sbf7j-0006FN-K3 for qemu-devel@nongnu.org; Mon, 04 Jun 2012 17:47:39 -0400 Date: Tue, 5 Jun 2012 00:47:37 +0300 From: "Michael S. Tsirkin" Message-ID: <20120604214736.GA2989@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 0/2] pci: hotplug bridge fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: pbonzini@redhat.com, alex.williamson@redhat.com, qemu-devel@nongnu.org, aliguori@us.ibm.com On Wed, May 02, 2012 at 10:42:06PM -0400, Jason Baron wrote: > Hi, > > While testing pci bridge hotplug via device_add, I ran into a couple of > qemu segfaults. > > The first one was caused by having a refcount greater than 0, in the > object_delete() path. Once, I got past that error, I hit a second > segfault due to the fact that pci_bridge_dev_initfn() didn't fully > cleanup its state. > > Thanks, > > -Jason Applied, thanks. > Jason Baron (2): > qdev: release parent properties on dc->init failure > pci_bridge_dev: fix error path in pci_bridge_dev_initfn() > > hw/pci_bridge_dev.c | 4 +++- > hw/qdev.c | 1 + > 2 files changed, 4 insertions(+), 1 deletions(-)