From: Luiz Capitulino <lcapitulino@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] Clean up includes of monitor.h
Date: Wed, 6 Jun 2012 14:44:25 -0300 [thread overview]
Message-ID: <20120606144425.4a514a8b@doriath.home> (raw)
In-Reply-To: <1338962922-21130-1-git-send-email-pbonzini@redhat.com>
On Wed, 6 Jun 2012 08:08:42 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> There is no reason why QAPI clients should use monitor.h at all,
> qerror.h suffices.
>
> qmp-commands.h uses the Monitor typedef, but it is only included
> from files that already get the typedef from qemu-common.h.
Could you please rebase it on top of the qmp queue?
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
I think you're going to get a few build errors there.
prev parent reply other threads:[~2012-06-06 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 6:08 [Qemu-devel] [PATCH 0/2] Clean up includes of monitor.h Paolo Bonzini
2012-06-06 6:09 ` [Qemu-devel] [PATCH 1/2] kvm: add missing include files Paolo Bonzini
2012-06-06 6:09 ` [Qemu-devel] [PATCH 2/2] qmp: do not include monitor.h from qapi-types-core.h Paolo Bonzini
2012-06-06 17:44 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606144425.4a514a8b@doriath.home \
--to=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).