From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60097)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1ScLV6-0003tf-Pq
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 15:02:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1ScLV4-0003wA-Tv
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 15:02:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1ScLV4-0003vo-Lv
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 15:02:34 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q56J2TaL031646
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 6 Jun 2012 15:02:33 -0400
Date: Wed, 6 Jun 2012 14:44:25 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120606144425.4a514a8b@doriath.home>
In-Reply-To: <1338962922-21130-1-git-send-email-pbonzini@redhat.com>
References: <1338962922-21130-1-git-send-email-pbonzini@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] Clean up includes of monitor.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed,  6 Jun 2012 08:08:42 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> There is no reason why QAPI clients should use monitor.h at all,
> qerror.h suffices.
> 
> qmp-commands.h uses the Monitor typedef, but it is only included
> from files that already get the typedef from qemu-common.h.

Could you please rebase it on top of the qmp queue?

 git://repo.or.cz/qemu/qmp-unstable.git queue/qmp

I think you're going to get a few build errors there.