From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScKh4-0006cB-Ji for qemu-devel@nongnu.org; Wed, 06 Jun 2012 14:10:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScKgy-0000i6-FJ for qemu-devel@nongnu.org; Wed, 06 Jun 2012 14:10:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScKgy-0000hi-4F for qemu-devel@nongnu.org; Wed, 06 Jun 2012 14:10:48 -0400 Date: Wed, 6 Jun 2012 14:50:34 -0300 From: Luiz Capitulino Message-ID: <20120606145034.19f141b7@doriath.home> In-Reply-To: <4FCF6367.8020409@linux.vnet.ibm.com> References: <1338815410-24890-1-git-send-email-coreyb@linux.vnet.ibm.com> <1338815410-24890-2-git-send-email-coreyb@linux.vnet.ibm.com> <20120605153058.01083bfd@doriath.home> <4FCF6367.8020409@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Wed, 06 Jun 2012 10:04:23 -0400 Corey Bryant wrote: > > Today, we return a dict on success: > > > > { "return": {} } > > > > But this patch changes it to: > > > > { "return": 42 } > > > > There are two ways to do this without breaking compatibility: > > > > 1. Add a new command (say get-file-descriptor) > > What do you think about using getfd2 for the command name? I'm thinking > getfd2 may be more obvious that it corresponds to closefd. We're going for more descriptive names in QMP. I don't have strong objections against get-fd2 if there's consensus that 'fd' is better than 'file-descriptor', although 'fd2' is a bit confusing. > That assumes > we'll use the same array internally to store fds and closefd can be used > to close the fd opened by get-file-descriptor/getfd2. You mean using the same array for getfd and get-file-descriptor? Yes, the descriptor list is global. > I assume this approach would still return an int: { "return": 42 } The new command? Yes. > > 2. Return a type instead, like: > > > > { "return": { "file-descriptor": 42 } } > > > > I think I prefer item 1, as we could also take the opportunity to fix the > > argument type and improve its name. Besides, we don't have a schema to do 2. > > Is it fdname that you think could be improved? fdname seems pretty > straight forward to me. What I'm trying to avoid is having too short names when that's not necessary. I think I'd just use 'name' or 'file-descriptor-name' for the verbose option, but I don't have strong objections against 'fdname'.