From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54517)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jbaron@redhat.com>) id 1ScdMY-0007Jo-FB
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 10:07:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jbaron@redhat.com>) id 1ScdMU-0001tj-Dx
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 10:06:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16643)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jbaron@redhat.com>) id 1ScdMU-0001tc-6Q
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 10:06:54 -0400
Date: Thu, 7 Jun 2012 10:06:50 -0400
From: Jason Baron <jbaron@redhat.com>
Message-ID: <20120607140649.GB12564@redhat.com>
References: <20120511145725.16518.77110.stgit@t>
	<1337507865-28504-1-git-send-email-kongjianjun@gmail.com>
	<20120604201556.GA2594@redhat.com>
	<20120604215202.GA3193@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120604215202.GA3193@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before
 free_qdev()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: pbonzini@redhat.com, Amos Kong <kongjianjun@gmail.com>, qemu-devel@nongnu.org, aliguori@us.ibm.com

On Tue, Jun 05, 2012 at 12:52:02AM +0300, Michael S. Tsirkin wrote:
> On Mon, Jun 04, 2012 at 04:15:56PM -0400, Jason Baron wrote:
> > On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote:
> > > Start VM with 8 multiple-function block devs, hot-removing
> > > those block devs by 'device_del ...' would cause qemu abort.
> > > 
> > > | (qemu) device_del virti0-0-0
> > > | (qemu) **
> > > |ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0)
> > > 
> > > It's a regression introduced by commit 57c9fafe
> > > 
> > 
> > I found a similar assertion where the parent reference isn't cleared,
> > doing:
> > 
> > (qemu) device_add pci-bridge
> > 
> > in the monitor. I posted for patches for it under:
> > 
> > Subject: [Qemu-devel] [PATCH 0/2] pci: hotplug bridge fixes
> > 
> > It's still an issue with the current tree.
> > 
> > Thanks,
> > 
> > -Jason
> 
> I pushed your patches on my tree pci branch, care to test
> there?
> 

Yes, fixes are confirmed.

Test case is quite simple:

(qemu) device_add pci_bridge

causes segfault without the 2 patches applied.

Thanks,

-Jason