From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.hallyn@canonical.com>) id 1Scdbu-0003Kv-T4
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 10:22:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.hallyn@canonical.com>) id 1Scdbp-0005Q8-NT
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 10:22:50 -0400
Received: from youngberry.canonical.com ([91.189.89.112]:35550)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.hallyn@canonical.com>) id 1Scdbp-0005Pz-HX
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 10:22:45 -0400
Date: Thu, 7 Jun 2012 09:22:38 -0500
From: Serge Hallyn <serge.hallyn@canonical.com>
Message-ID: <20120607142238.GA4210@sergelap>
References: <1339047357-29413-1-git-send-email-sw@weilnetz.de>
	<alpine.DEB.2.02.1206071120480.2415@kaball.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1206071120480.2415@kaball.uk.xensource.com>
Subject: Re: [Qemu-devel] [PATCH] configure: Fix build for some versions of
	glibc (9pfs)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Stefan Weil <sw@weilnetz.de>, Anthony Liguori <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "aneesh.kumar@linux.vnet.ibm.com" <aneesh.kumar@linux.vnet.ibm.com>

Quoting Stefano Stabellini (stefano.stabellini@eu.citrix.com):
> On Thu, 7 Jun 2012, Stefan Weil wrote:
> > Some versions declare open_by_handle_at, but don't define AT_EMPTY_PATH.
> > Extend the check in configure to test both preconditions.
> > 
> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> 
> It works for me. Also I think it is a better fix than the original
> patch.

Well, it works in that it allows compilation to proceed.  It results
in ./libhw64/9pfs/virtio-9p-handle.o not being built, since AT_EMPTY_PATH
can't be found through /usr/include/fcntl.h, even though it can in
/usr/include/linux/fcntl.h.  I guess that is, unfortunately, the right
thing to do.

Oh hey, I think I've found the bug in the debian package causing
that problem.  Grr.

> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Acked-by: Serge Hallyn <serge.hallyn@ubuntu.com>

thanks,
-serge

> 
> >  configure |    4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/configure b/configure
> > index 799ad0f..f737f6c 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2816,7 +2816,11 @@ fi
> >  open_by_hande_at=no
> >  cat > $TMPC << EOF
> >  #include <fcntl.h>
> > +#if !defined(AT_EMPTY_PATH)
> > +# error missing definition
> > +#else
> >  int main(void) { struct file_handle fh; return open_by_handle_at(0, &fh, 0); }
> > +#endif
> >  EOF
> >  if compile_prog "" "" ; then
> >      open_by_handle_at=yes
> > -- 
> > 1.7.10
> >