From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SdNSX-0005sA-9y for qemu-devel@nongnu.org; Sat, 09 Jun 2012 11:20:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SdNSV-0003c7-KQ for qemu-devel@nongnu.org; Sat, 09 Jun 2012 11:20:12 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:35447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SdNSV-0003ba-Az for qemu-devel@nongnu.org; Sat, 09 Jun 2012 11:20:11 -0400 Received: by bkwj10 with SMTP id j10so2705240bkw.4 for ; Sat, 09 Jun 2012 08:20:08 -0700 (PDT) Date: Sat, 9 Jun 2012 17:20:03 +0200 From: "Edgar E. Iglesias" Message-ID: <20120609152003.GA5062@zapo> References: <1339206871-4706-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1339206871-4706-1-git-send-email-afaerber@suse.de> Subject: Re: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Blue Swirl , Paolo Bonzini , "Peter A. G. Crosthwaite" , qemu-devel@nongnu.org, Alexander Graf On Sat, Jun 09, 2012 at 03:54:28AM +0200, Andreas Färber wrote: > Hello Edgar and Peter, > > With the Makefile refactoring applied now, here's the Makefile improvements > for MicroBlaze I mentioned. > > All Xilinx devices that are used for more than one softmmu are compiled once > in libhw32. Actually some also in libhw64 due to ppc440 being compiled into > ppc64, but we can fix that in a second step via Alex' ppc-next, we're already > down from thrice to twice. > > The middle patch is extracted from Blue's logging refactoring. > > Please test and apply. Your s3adp1800 and virtel_ml507 test images complain > both with and without patches about not finding "eth0". Selftest completes ok > except for not finding /usr/bin/sha1test on ppc440. Thanks, I'll give these a try next week! > > xilinx_ethlite.c uses tswap32(). Have you ever tested this device to work on > microblazeel? I wonder if we could change the device from DEVICE_NATIVE_ENDIAN > to DEVICE_BIG_ENDIAN and in place of tswap32() use a bswap32() conditional on > HOST_WORDS_BIGENDIAN so that it becomes independent of the target, too? I don't think that will work. the swap is needed if the endianness of the host is different from the one of the target... IIRC, the issue is that the device has a built-in RAM mapped so close to the regs that they end up in the same "page". With Avis memory-api maybe it's possible to expose this sub-page area as a memory? Cheers